fix ПроверкаМакетовСКД#806
Merged
artbear merged 3 commits intoNov 8, 2020
Hidden character warning
The head ref may contain hidden characters: "fix-\u0422\u0435\u0441\u0442\u044b_\u041f\u0440\u043e\u0432\u0435\u0440\u043a\u0430\u041c\u0430\u043a\u0435\u0442\u0421\u041a\u0414"
Merged
Conversation
artbear
requested changes
Nov 7, 2020
artbear
left a comment
artbear
left a comment
Collaborator
There was a problem hiding this comment.
Есть достаточно критическое замечание.
и главный вопрос - зачем нужны эти правки, ведь тест макетов СКД прекрасно работает как серверный тест в тонком клиенте.
зачем тебе понадобилось делать текущую доработку?
Contributor
Author
@artbear 852 скд макета в конфе: Это с открытием и выполнением теста |
artbear
reviewed
Nov 8, 2020
Collaborator
|
По оптимизации понял, да, серьезное отличие! |
Collaborator
|
@SidnevAV Замечательно! принято. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
сделанные изменения
@vanessa-opensource/Collaborators - просьба прокомментировать и проверить