Repository navigation
fix(fs): reject zero-length suffix byte ranges - #2460
Merged
erikdubbelboer merged 1 commit intoOct 5, 2026
Merged
Conversation
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParseByteRangeaccepts the suffix rangebytes=-0and returnsstartPos = contentLength,endPos = contentLength - 1. The FS handler then replies206 Partial Contentwith an empty body and an invalidContent-Range:RFC 9110 §14.1.1 only treats a suffix range as satisfiable when its suffix-length is non-zero, so this should be
416 Range Not Satisfiable. Every other unsatisfiable range already gets that response through the error path.ParseByteRangenow returns an error for a zero suffix length.Added
bytes=-0toTestParseByteRangeError; it fails without the change.go test .andgo vet .pass.