fix(pprofhandler): use exact path matching to prevent prefix-based route confusion#2262
Open
toller892 wants to merge 1 commit into
Open
fix(pprofhandler): use exact path matching to prevent prefix-based route confusion#2262toller892 wants to merge 1 commit into
toller892 wants to merge 1 commit into
Conversation
…ute confusion PprofHandler previously used bytes.HasPrefix for matching pprof endpoint paths, which meant /debug/pprof/cmdlineEvil would incorrectly match the cmdline handler. Switch to bytes.Equal for the four named handlers (cmdline, profile, symbol, trace) and add proper boundary checking for runtime profile names in the default case. Fixes valyala#2258
erikdubbelboer
requested changes
Jun 6, 2026
| "github.com/valyala/fasthttp/fasthttputil" | ||
| ) | ||
|
|
||
| func TestPprofHandler_PathMatching(t *testing.T) { |
Collaborator
There was a problem hiding this comment.
Can you please remove the test. This is such a simple change, it doesn't need this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PprofHandler uses for matching pprof endpoint paths. This means paths like incorrectly match the handler, matches , etc.
Fixes #2258
Fix
Switch from to for the four named handlers (cmdline, profile, symbol, trace). For runtime profile names in the default case, check that the path either exactly matches or has a trailing slash boundary.
Changes:
Testing
All existing functionality preserved — exact paths still resolve correctly. Malicious/malformed paths with extra suffixes no longer match specific handlers.