Avoid to re-establish replication if node is already myself primary in CLUSTER REPLICATE#884
Merged
enjoy-binbin merged 3 commits intovalkey-io:unstablefrom Aug 22, 2024
Conversation
…n CLUSTER REPLICATE If n is already myself primary, there is no need to re-establish the replication connection. Signed-off-by: Binbin <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #884 +/- ##
============================================
- Coverage 70.62% 70.57% -0.05%
============================================
Files 112 112
Lines 61509 61512 +3
============================================
- Hits 43440 43412 -28
- Misses 18069 18100 +31
🚀 New features to boost your workflow:
|
PingXie
approved these changes
Aug 12, 2024
Member
PingXie
left a comment
PingXie
left a comment
There was a problem hiding this comment.
I can't think of anything that could go wrong but it is indeed a behavior change.
@valkey-io/core-team FYI
PingXie
added
the
release-notes
Co-authored-by: Ping Xie <[email protected]> Signed-off-by: Binbin <[email protected]>
zuiderkwast
approved these changes
Aug 15, 2024
…er_replicate Signed-off-by: Binbin <[email protected]>
Member
Author
|
I am merging this since #885 is merged, see top comment for more details |
madolson
pushed a commit
that referenced
this pull request
Sep 2, 2024
…n CLUSTER REPLICATE (#884) If n is already myself primary, there is no need to re-establish the replication connection. In the past we allow a replica node to reconnect with its primary via this CLUSTER REPLICATE command, it will use psync. But since #885, we will assume that a full sync is needed in this case, so if we don't do this, the replica will always use full sync. Signed-off-by: Binbin <[email protected]> Co-authored-by: Ping Xie <[email protected]>
madolson
pushed a commit
that referenced
this pull request
Sep 3, 2024
…n CLUSTER REPLICATE (#884) If n is already myself primary, there is no need to re-establish the replication connection. In the past we allow a replica node to reconnect with its primary via this CLUSTER REPLICATE command, it will use psync. But since #885, we will assume that a full sync is needed in this case, so if we don't do this, the replica will always use full sync. Signed-off-by: Binbin <[email protected]> Co-authored-by: Ping Xie <[email protected]>
PingXie
pushed a commit
to PingXie/valkey
that referenced
this pull request
Sep 14, 2024
…n CLUSTER REPLICATE (valkey-io#884) If n is already myself primary, there is no need to re-establish the replication connection. In the past we allow a replica node to reconnect with its primary via this CLUSTER REPLICATE command, it will use psync. But since valkey-io#885, we will assume that a full sync is needed in this case, so if we don't do this, the replica will always use full sync. Signed-off-by: Binbin <[email protected]> Co-authored-by: Ping Xie <[email protected]>
PingXie
pushed a commit
to PingXie/valkey
that referenced
this pull request
Sep 14, 2024
…n CLUSTER REPLICATE (valkey-io#884) If n is already myself primary, there is no need to re-establish the replication connection. In the past we allow a replica node to reconnect with its primary via this CLUSTER REPLICATE command, it will use psync. But since valkey-io#885, we will assume that a full sync is needed in this case, so if we don't do this, the replica will always use full sync. Signed-off-by: Binbin <[email protected]> Co-authored-by: Ping Xie <[email protected]>
PingXie
pushed a commit
to PingXie/valkey
that referenced
this pull request
Sep 14, 2024
…n CLUSTER REPLICATE (valkey-io#884) If n is already myself primary, there is no need to re-establish the replication connection. In the past we allow a replica node to reconnect with its primary via this CLUSTER REPLICATE command, it will use psync. But since valkey-io#885, we will assume that a full sync is needed in this case, so if we don't do this, the replica will always use full sync. Signed-off-by: Binbin <[email protected]> Co-authored-by: Ping Xie <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If n is already myself primary, there is no need to re-establish the
replication connection.
In the past we allow a replica node to reconnect with its primary via
this CLUSTER REPLICATE command, it will use psync. But since #885, we
will assume that a full sync is needed in this case, so if we don't do
this, the replica will always use full sync.