Added a flag to run additional tests for additional tests#815
Merged
PingXie merged 6 commits intovalkey-io:unstablefrom Jul 23, 2024
Merged
Added a flag to run additional tests for additional tests#815PingXie merged 6 commits intovalkey-io:unstablefrom
PingXie merged 6 commits intovalkey-io:unstablefrom
Conversation
Signed-off-by: Madelyn Olson <[email protected]>
madolson
added
the
run-extra-tests
Signed-off-by: Madelyn Olson <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #815 +/- ##
============================================
- Coverage 70.36% 70.31% -0.06%
============================================
Files 112 112
Lines 61275 61275
============================================
- Hits 43115 43084 -31
- Misses 18160 18191 +31 |
Signed-off-by: Madelyn Olson <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
PingXie
approved these changes
Jul 23, 2024
hwware
pushed a commit
to hwware/valkey
that referenced
this pull request
Jul 25, 2024
) This PR allows running a subset of the daily tests with a PR by attaching the `run-extra-tests` flag. This is done by conditionally running the daily tests when the label is attached. (I will do that for this PR to demonstrate). One downside of this PR is that a lot of tests will forever show-up as "skipped" for most PRs, as long as that doesn't bother us it should be OK. Skipped tests don't take up any of our runner compute. Another note, if the label isn't attached on the first commit, the submitter will need to push something to get the tests to run again. There is a way to make it kick off tests during a label, but that added a bunch more complexity so just wanted to start with this. --------- Signed-off-by: Madelyn Olson <[email protected]>
This was referenced Nov 5, 2025
dmitrypol
pushed a commit
to dmitrypol/valkey
that referenced
this pull request
Nov 6, 2025
Signed-off-by: Dmitry Polyakovsky <[email protected]>
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Jan 30, 2026
) This PR allows running a subset of the daily tests with a PR by attaching the `run-extra-tests` flag. This is done by conditionally running the daily tests when the label is attached. (I will do that for this PR to demonstrate). One downside of this PR is that a lot of tests will forever show-up as "skipped" for most PRs, as long as that doesn't bother us it should be OK. Skipped tests don't take up any of our runner compute. Another note, if the label isn't attached on the first commit, the submitter will need to push something to get the tests to run again. There is a way to make it kick off tests during a label, but that added a bunch more complexity so just wanted to start with this. --------- Signed-off-by: Madelyn Olson <[email protected]>
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Jan 30, 2026
) This PR allows running a subset of the daily tests with a PR by attaching the `run-extra-tests` flag. This is done by conditionally running the daily tests when the label is attached. (I will do that for this PR to demonstrate). One downside of this PR is that a lot of tests will forever show-up as "skipped" for most PRs, as long as that doesn't bother us it should be OK. Skipped tests don't take up any of our runner compute. Another note, if the label isn't attached on the first commit, the submitter will need to push something to get the tests to run again. There is a way to make it kick off tests during a label, but that added a bunch more complexity so just wanted to start with this. --------- Signed-off-by: Madelyn Olson <[email protected]> Signed-off-by: Roshan Khatri <[email protected]>
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 19, 2026
) This PR allows running a subset of the daily tests with a PR by attaching the `run-extra-tests` flag. This is done by conditionally running the daily tests when the label is attached. (I will do that for this PR to demonstrate). One downside of this PR is that a lot of tests will forever show-up as "skipped" for most PRs, as long as that doesn't bother us it should be OK. Skipped tests don't take up any of our runner compute. Another note, if the label isn't attached on the first commit, the submitter will need to push something to get the tests to run again. There is a way to make it kick off tests during a label, but that added a bunch more complexity so just wanted to start with this. --------- Signed-off-by: Madelyn Olson <[email protected]> Signed-off-by: Roshan Khatri <[email protected]>
hpatro
pushed a commit
that referenced
this pull request
Feb 24, 2026
This PR allows running a subset of the daily tests with a PR by attaching the `run-extra-tests` flag. This is done by conditionally running the daily tests when the label is attached. (I will do that for this PR to demonstrate). One downside of this PR is that a lot of tests will forever show-up as "skipped" for most PRs, as long as that doesn't bother us it should be OK. Skipped tests don't take up any of our runner compute. Another note, if the label isn't attached on the first commit, the submitter will need to push something to get the tests to run again. There is a way to make it kick off tests during a label, but that added a bunch more complexity so just wanted to start with this. --------- Signed-off-by: Madelyn Olson <[email protected]> Signed-off-by: Roshan Khatri <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows running a subset of the daily tests with a PR by attaching the
run-extra-testsflag. This is done by conditionally running the daily tests when the label is attached. (I will do that for this PR to demonstrate).One downside of this PR is that a lot of tests will forever show-up as "skipped" for most PRs, as long as that doesn't bother us it should be OK. Skipped tests don't take up any of our runner compute.
Another note, if the label isn't attached on the first commit, the submitter will need to push something to get the tests to run again. There is a way to make it kick off tests during a label, but that added a bunch more complexity so just wanted to start with this.