Correct the actual allocated size from allocator when call sdsRedize to align the logic with sdsnewlen function.#476
Conversation
zhulipeng
force-pushed
the
sds_header
branch
2 times, most recently
from
1a73354 to
9b30c8a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #476 +/- ##
=========================================
Coverage 69.84% 69.84%
=========================================
Files 109 109
Lines 61797 61801 +4
=========================================
+ Hits 43160 43163 +3
- Misses 18637 18638 +1
|
|
Right, I did very similar changes. Didn't push yet. |
Signed-off-by: Lipeng Zhu <[email protected]>
zhulipeng
changed the title
zhulipeng
changed the title
madolson
left a comment
madolson
left a comment
There was a problem hiding this comment.
This looks good to me, can you move the tests to the new framework?
Signed-off-by: Lipeng Zhu <[email protected]>
Done. |
madolson
left a comment
madolson
left a comment
There was a problem hiding this comment.
A nice to have, but not necessarily in the scope of this PR, is we should probably add more checks that sdsalloc() is actually always equal to the underlying zmalloc allocation size.
|
Just to clarify, underlying allocation size equals to |
|
@lipzhu A test started to fail after we merged this change related to allocated size: It's the libc malloc function, let me know if you think it's related and if you can try to fix it. |
…to align the logic with sdsnewlen function. (valkey-io#476) This patch try to correct the actual allocated size from allocator when call sdsRedize to align the logic with sdsnewlen function. Maybe the valkey-io#453 optimization should depend on this. Signed-off-by: Lipeng Zhu <[email protected]>
|
@madolson Sure, I will take a look and try to reproduce in local. |
Make `sdsResize` logic align with `_sdsnewlen`, fix of #476. Fix: https://github.com/valkey-io/valkey/actions/runs/9143545732/job/25140329542#step:6:1505 https://github.com/valkey-io/valkey/actions/runs/9135654696/job/25123330670#step:6:1501 Signed-off-by: Lipeng Zhu <[email protected]>
…to align the logic with sdsnewlen function. (valkey-io#476) This patch try to correct the actual allocated size from allocator when call sdsRedize to align the logic with sdsnewlen function. Maybe the valkey-io#453 optimization should depend on this. Signed-off-by: Lipeng Zhu <[email protected]> Signed-off-by: Samuel Adetunji <[email protected]>
) Make `sdsResize` logic align with `_sdsnewlen`, fix of valkey-io#476. Fix: https://github.com/valkey-io/valkey/actions/runs/9143545732/job/25140329542#step:6:1505 https://github.com/valkey-io/valkey/actions/runs/9135654696/job/25123330670#step:6:1501 Signed-off-by: Lipeng Zhu <[email protected]> Signed-off-by: Samuel Adetunji <[email protected]>
3 participants
This patch try to correct the actual allocated size from allocator
when call sdsRedize to align the logic with sdsnewlen function.
Maybe the #453 optimization should depend on this.