Migrate cluster mode tests to normal framework#442
Merged
enjoy-binbin merged 4 commits intovalkey-io:unstablefrom May 9, 2024
Merged
Migrate cluster mode tests to normal framework#442enjoy-binbin merged 4 commits intovalkey-io:unstablefrom
enjoy-binbin merged 4 commits intovalkey-io:unstablefrom
Conversation
We currently has two disjoint TCL frameworks: 1. Normal testing framework, which trigger by runtest, which individually launches nodes for testing. 2. Cluster framework, which trigger by runtest-cluster, which pre-allocates N nodes and uses them for testing large configurations. The normal TCL testing framework is much more readily tested and is also automatically run as part of the CI for new PRs. The runtest-cluster since it runs very slowly (cannot be parallelized), it currently only runs in daily CI, this results in some changes to the cluster not being exposed in PR CI in time. This PR migrate the Cluster mode tests to normal framework. Some cluster tests are kept in runtest-cluster because of timing issues or not yet supported, we can process them later. Signed-off-by: Binbin <[email protected]>
enjoy-binbin
force-pushed
the
migrate_clustertest
branch
from
ae57ba6 to
8906faa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #442 +/- ##
============================================
+ Coverage 68.88% 69.83% +0.94%
============================================
Files 109 109
Lines 61793 61793
============================================
+ Hits 42566 43153 +587
+ Misses 19227 18640 -587 |
madolson
approved these changes
May 8, 2024
Member
madolson
left a comment
madolson
left a comment
There was a problem hiding this comment.
Overall LGTM. Assuming after the merge the new tests Ping enabled still work, I would be good to merge this.
…test Signed-off-by: Binbin <[email protected]>
Signed-off-by: Binbin <[email protected]>
Signed-off-by: Binbin <[email protected]>
karthyuom
pushed a commit
to karthyuom/valkey
that referenced
this pull request
May 13, 2024
We currently has two disjoint TCL frameworks: 1. Normal testing framework, which trigger by runtest, which individually launches nodes for testing. 2. Cluster framework, which trigger by runtest-cluster, which pre-allocates N nodes and uses them for testing large configurations. The normal TCL testing framework is much more readily tested and is also automatically run as part of the CI for new PRs. The runtest-cluster since it runs very slowly (cannot be parallelized), it currently only runs in daily CI, this results in some changes to the cluster not being exposed in PR CI in time. This PR migrate the Cluster mode tests to normal framework. Some cluster tests are kept in runtest-cluster because of timing issues or not yet supported, we can process them later. Signed-off-by: Binbin <[email protected]> Signed-off-by: Karthick Ariyaratnam <[email protected]>
srgsanky
pushed a commit
to srgsanky/valkey
that referenced
this pull request
May 19, 2024
We currently has two disjoint TCL frameworks: 1. Normal testing framework, which trigger by runtest, which individually launches nodes for testing. 2. Cluster framework, which trigger by runtest-cluster, which pre-allocates N nodes and uses them for testing large configurations. The normal TCL testing framework is much more readily tested and is also automatically run as part of the CI for new PRs. The runtest-cluster since it runs very slowly (cannot be parallelized), it currently only runs in daily CI, this results in some changes to the cluster not being exposed in PR CI in time. This PR migrate the Cluster mode tests to normal framework. Some cluster tests are kept in runtest-cluster because of timing issues or not yet supported, we can process them later. Signed-off-by: Binbin <[email protected]>
This was referenced Jul 9, 2024
enjoy-binbin
added a commit
to enjoy-binbin/valkey
that referenced
this pull request
Jul 14, 2024
It was introduced wrong in valkey-io#442. Signed-off-by: Binbin <[email protected]>
enjoy-binbin
added a commit
that referenced
this pull request
Jul 19, 2024
It was introduced wrong in #442. Signed-off-by: Binbin <[email protected]>
hwware
pushed a commit
to hwware/valkey
that referenced
this pull request
Jul 25, 2024
It was introduced wrong in valkey-io#442. Signed-off-by: Binbin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently has two disjoint TCL frameworks:
launches nodes for testing.
N nodes and uses them for testing large configurations.
The normal TCL testing framework is much more readily tested and is also
automatically run as part of the CI for new PRs. The runtest-cluster since
it runs very slowly (cannot be parallelized), it currently only runs in daily
CI, this results in some changes to the cluster not being exposed in PR CI
in time.
This PR migrate the Cluster mode tests to normal framework. Some cluster
tests are kept in runtest-cluster because of timing issues or not yet
supported, we can process them later.