Deflake "Replica output bytes metric" with atomic stats capture - #4102

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

tests/integration/replication.tcl (1)

198-209: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Add the missing repl-ping-replica-period configuration.

Without this setting, a periodic PING could still arrive during the verification window, incrementing the replication output bytes and allowing the test to pass incorrectly even if the SET command wasn't properly accounted for.

Based on the PR objectives, the test should raise repl-ping-replica-period to 3600 to prevent queued or future PINGs from affecting total_net_repl_output_bytes during the assertion. Based on past review comments, this is needed to prevent a false positive test.

🐛 Proposed fix

         test {Replica output bytes metric} {
+            # Prevent periodic PINGs from inflating the output bytes metric and causing false positives
+            $A config set repl-ping-replica-period 3600
+
             # Make sure no replication traffic (initial sync, backlog writes)
             # is still in flight before resetting stats, so the zero-baseline
             # assertion below doesn't race with it.
             wait_for_ofs_sync $A $B
 
             # Reset stats and read them atomically so replication traffic can't
             # arrive between the reset and the stats snapshot.
             $A multi
             $A config resetstat
             $A info stats
             set info [lindex [$A exec] 1]

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

        test {Replica output bytes metric} {
            # Prevent periodic PINGs from inflating the output bytes metric and causing false positives
            $A config set repl-ping-replica-period 3600

            # Make sure no replication traffic (initial sync, backlog writes)
            # is still in flight before resetting stats, so the zero-baseline
            # assertion below doesn't race with it.
            wait_for_ofs_sync $A $B

            # Reset stats and read them atomically so replication traffic can't
            # arrive between the reset and the stats snapshot.
            $A multi
            $A config resetstat
            $A info stats
            set info [lindex [$A exec] 1]

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/integration/replication.tcl` around lines 198 - 209, In the test
{Replica output bytes metric}, configure replica pinging to be effectively
disabled for the verification window by setting repl-ping-replica-period to 3600
before resetting stats and capturing the baseline. Keep the existing
wait_for_ofs_sync and atomic stats-reset sequence intact so only the intended
replication traffic affects total_net_repl_output_bytes.