Fix large-memory tests by reducing allocation size#3224
Merged
zuiderkwast merged 2 commits intovalkey-io:unstablefrom Feb 17, 2026
Merged
Fix large-memory tests by reducing allocation size#3224zuiderkwast merged 2 commits intovalkey-io:unstablefrom
zuiderkwast merged 2 commits intovalkey-io:unstablefrom
Conversation
Signed-off-by: Nikhil Manglore <[email protected]>
Signed-off-by: Nikhil Manglore <[email protected]>
Contributor
sarthakaggarwal97
left a comment
sarthakaggarwal97
left a comment
There was a problem hiding this comment.
@Nikhil-Manglore nice! Can you also link a daily test link from your forked repo?
sarthakaggarwal97
approved these changes
Feb 17, 2026
Member
Author
|
@sarthakaggarwal97 https://github.com/Nikhil-Manglore/valkey/actions/runs/22112870882/job/63913353155 The test-sanitizer-undefined-large-memory for gcc and clang both pass now. I'll keep the original issue open since we're still getting failures for the sanitizer address |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3224 +/- ##
================================
================================
🚀 New features to boost your workflow:
|
harrylin98
pushed a commit
to harrylin98/valkey_forked
that referenced
this pull request
Feb 19, 2026
Large-memory tests were failing with "I/O error reading reply" after the first test `EVAL - JSON string encoding a string larger than 2GB`. Three tests that shared a single server instance led to cascading failures when the first test's 3GB allocation left the server in a memory-stressed state. This PR isolates each test by starting its own server. Additionally, I've reduced the JSON encoding test size from 3GB to 2.25GB. This included changing the allocated 1GB string (concatenated 3x) to a 750MB string to avoid memory exhaustion while still testing strings greater than 2GB like we intended. --------- Signed-off-by: Nikhil Manglore <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large-memory tests were failing with "I/O error reading reply" after the first test
EVAL - JSON string encoding a string larger than 2GB. Three tests that shared a single server instance led to cascading failures when the first test's 3GB allocation left the server in a memory-stressed state.This PR isolates each test by starting its own server. Additionally, I've reduced the JSON encoding test size from 3GB to 2.25GB. This included changing the allocated 1GB string (concatenated 3x) to a 750MB string to avoid memory exhaustion while still testing strings greater than 2GB like we intended.