Fix database ACL check for alldbs commands#3215
Merged
zuiderkwast merged 1 commit intovalkey-io:unstablefrom Feb 16, 2026
Merged
Fix database ACL check for alldbs commands#3215zuiderkwast merged 1 commit intovalkey-io:unstablefrom
zuiderkwast merged 1 commit intovalkey-io:unstablefrom
Conversation
Signed-off-by: Daniil Kashapov <[email protected]>
zuiderkwast
approved these changes
Feb 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3215 +/- ##
================================
================================
🚀 New features to boost your workflow:
|
harrylin98
pushed a commit
to harrylin98/valkey_forked
that referenced
this pull request
Feb 19, 2026
At one point in development there was assumption that intset of database IDs would have IDs only in `[0, server.dbnum-1]` range, but [here](valkey-io#2309 (comment)) we decided to change upper bound to `INT32_MAX` for ACL compatibility reasons between nodes. Because of that change, assumption is not true anymore and we should explicitly check each database list to contain access to full `[0, server.dbnum-1]` range. Also added test for that. Signed-off-by: Daniil Kashapov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At one point in development there was assumption that intset of database IDs would have IDs only in
[0, server.dbnum-1]range, but here we decided to change upper bound toINT32_MAXfor ACL compatibility reasons between nodes.Because of that change, assumption is not true anymore and we should explicitly check each database list to contain access to full
[0, server.dbnum-1]range.Also added test for that.