Fixes run-extra-tests workflow to run on the PR commit instead of unstable#3092
Merged
madolson merged 1 commit intovalkey-io:unstablefrom Jan 21, 2026
Merged
Conversation
Signed-off-by: Sarthak Aggarwal <[email protected]>
sarthakaggarwal97
added
the
run-extra-tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3092 +/- ##
============================================
- Coverage 74.32% 74.31% -0.01%
============================================
Files 129 129
Lines 71011 71011
============================================
- Hits 52778 52773 -5
- Misses 18233 18238 +5 🚀 New features to boost your workflow:
|
madolson
approved these changes
Jan 21, 2026
Member
madolson
left a comment
madolson
left a comment
There was a problem hiding this comment.
Need this to make it easier to approve other prs.
github-actions
bot
removed
the
run-extra-tests
arshidkv12
pushed a commit
to arshidkv12/valkey
that referenced
this pull request
Jan 23, 2026
…table (valkey-io#3092) Thanks madolson for pointing out the issue with valkey-io#2907. Whenever we were using the label, it was picking up the head of the unstable instead of the PR. The reason was that we changed the target to `pull_request_target`. We had to do that since we wanted to remove the label after the run is completed. With this change, it correctly picks up the commit hash of the PR and checks it out. To test this, I merged the changes in my forked repository's [unstable](valkey-io/valkey@unstable...sarthakaggarwal97:valkey:unstable), created a dummy [PR](sarthakaggarwal97#61), and was able to verify that the commit of the PR is being checked out in the [action](https://github.com/sarthakaggarwal97/valkey/actions/runs/21229598167/job/61084986422?pr=61#step:3:81). Signed-off-by: Sarthak Aggarwal <[email protected]> Signed-off-by: arshidkv12 <[email protected]>
harrylin98
pushed a commit
to harrylin98/valkey_forked
that referenced
this pull request
Feb 19, 2026
…table (valkey-io#3092) Thanks madolson for pointing out the issue with valkey-io#2907. Whenever we were using the label, it was picking up the head of the unstable instead of the PR. The reason was that we changed the target to `pull_request_target`. We had to do that since we wanted to remove the label after the run is completed. With this change, it correctly picks up the commit hash of the PR and checks it out. To test this, I merged the changes in my forked repository's [unstable](valkey-io/valkey@unstable...sarthakaggarwal97:valkey:unstable), created a dummy [PR](sarthakaggarwal97#61), and was able to verify that the commit of the PR is being checked out in the [action](https://github.com/sarthakaggarwal97/valkey/actions/runs/21229598167/job/61084986422?pr=61#step:3:81). Signed-off-by: Sarthak Aggarwal <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks @madolson for pointing out the issue with #2907.
Whenever we were using the label, it was picking up the head of the unstable instead of the PR. The reason was that we changed the target to
pull_request_target. We had to do that since we wanted to remove the label after the run is completed.With this change, it correctly picks up the commit hash of the PR and checks it out.
To test this, I merged the changes in my forked repository's unstable, created a dummy PR, and was able to verify that the commit of the PR is being checked out in the action.