Revert hgetall dynamic deferred response #2981
Merged
ranshid merged 1 commit intovalkey-io:unstablefrom Dec 28, 2025
Merged
Conversation
ranshid
added
the
run-extra-tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #2981 +/- ##
============================================
- Coverage 73.90% 73.75% -0.16%
============================================
Files 125 125
Lines 69351 69347 -4
============================================
- Hits 51251 51144 -107
- Misses 18100 18203 +103
🚀 New features to boost your workflow:
|
github-actions
bot
removed
the
run-extra-tests
Member
enjoy-binbin
left a comment
enjoy-binbin
left a comment
There was a problem hiding this comment.
i see the tests are still failing
Member
Author
@enjoy-binbin yes. I based the fix on running them on my private fork, and thet passed. I am happy it does not solve the issue, since it would then be something I could not explain. |
ranshid
force-pushed
the
fix-daily-tests
branch
from
e642a52 to
e045fc0
Compare
This reverts commit 75707ac. Signed-off-by: Ran Shidlansik <[email protected]>
ranshid
force-pushed
the
fix-daily-tests
branch
from
e045fc0 to
e9ea8ca
Compare
Member
Author
|
I will try to just revert the last fix at this point and reattempt to add it after |
enjoy-binbin
approved these changes
Dec 26, 2025
ranshid
changed the title
jdheyburn
pushed a commit
to jdheyburn/valkey
that referenced
this pull request
Jan 8, 2026
This is to fix a regression introduced in valkey-io#2966. Example failed run: https://github.com/valkey-io/valkey/actions/runs/20495981119/job/58895602847 Currently reverting the commit which introduced the regression Signed-off-by: Ran Shidlansik <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix a regression introduced in #2966.
Example failed run: https://github.com/valkey-io/valkey/actions/runs/20495981119/job/58895602847
Currently is is still not clear why adding the assertion solves the problem, which is still to be RCAd