Avoid hgetall deferred response#2966
Merged
ranshid merged 4 commits intovalkey-io:unstablefrom Dec 24, 2025
Merged
Conversation
Signed-off-by: Ran Shidlansik <[email protected]>
Signed-off-by: Ran Shidlansik <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #2966 +/- ##
============================================
+ Coverage 73.73% 73.81% +0.07%
============================================
Files 125 125
Lines 68911 69351 +440
============================================
+ Hits 50813 51189 +376
- Misses 18098 18162 +64
🚀 New features to boost your workflow:
|
enjoy-binbin
approved these changes
Dec 23, 2025
zuiderkwast
approved these changes
Dec 23, 2025
Signed-off-by: Ran Shidlansik <[email protected]>
ranshid
added a commit
to ranshid/valkey
that referenced
this pull request
Dec 26, 2025
This reverts commit 75707ac.
ranshid
added a commit
to ranshid/valkey
that referenced
this pull request
Dec 26, 2025
This reverts commit 75707ac. Signed-off-by: Ran Shidlansik <[email protected]>
ranshid
added a commit
that referenced
this pull request
Dec 28, 2025
This is to fix a regression introduced in #2966. Example failed run: https://github.com/valkey-io/valkey/actions/runs/20495981119/job/58895602847 Currently reverting the commit which introduced the regression Signed-off-by: Ran Shidlansik <[email protected]>
jdheyburn
pushed a commit
to jdheyburn/valkey
that referenced
this pull request
Jan 8, 2026
In valkey-io#2089 we added a deferred logic for HGETALL since we cannot anticipate the size of the output as it may contain expired hash items which should not be included. As part of the work of valkey-io#2022 this would greatly increase the time for HGETALL processing, thus we introduce this minor improvement to avoid using deferred reply in case the hash has NO volatile items. --------- Signed-off-by: Ran Shidlansik <[email protected]>
jdheyburn
pushed a commit
to jdheyburn/valkey
that referenced
this pull request
Jan 8, 2026
This is to fix a regression introduced in valkey-io#2966. Example failed run: https://github.com/valkey-io/valkey/actions/runs/20495981119/job/58895602847 Currently reverting the commit which introduced the regression Signed-off-by: Ran Shidlansik <[email protected]>
Uzay-G
added a commit
to fulcrumresearch/valkey
that referenced
this pull request
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #2089 we added a deferred logic for HGETALL since we cannot anticipate the size of the output as it may contain expired hash items which should not be included.
As part of the work of #2022 this would greatly increase the time for HGETALL processing, thus we introduce this minor improvement to avoid using deferred reply in case the hash has NO volatile items.