Free replica local buffer in async way in dual channel replication#2948
Merged
enjoy-binbin merged 3 commits intovalkey-io:unstablefrom Jan 30, 2026
Merged
Free replica local buffer in async way in dual channel replication#2948enjoy-binbin merged 3 commits intovalkey-io:unstablefrom
enjoy-binbin merged 3 commits intovalkey-io:unstablefrom
Conversation
In dual channel replication, when the replica abort the replication, if the local buffer is huge, free it in async way to avoid the latency. Dual channel replication was introduced in valkey-io#60. Signed-off-by: Binbin <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #2948 +/- ##
============================================
+ Coverage 74.69% 74.77% +0.07%
============================================
Files 129 129
Lines 71199 71210 +11
============================================
+ Hits 53185 53249 +64
+ Misses 18014 17961 -53
🚀 New features to boost your workflow:
|
naglera
reviewed
Dec 21, 2025
Contributor
naglera
left a comment
naglera
left a comment
There was a problem hiding this comment.
Left couple of comments, also pointing out that the replication buffer streaming operation is also blocking, however it will require more work. We might want to solve this as well on a seprate PR.
enjoy-binbin
added
the
run-extra-tests
Signed-off-by: Binbin <[email protected]>
naglera
approved these changes
Dec 28, 2025
Signed-off-by: Binbin <[email protected]>
murphyjacob4
approved these changes
Jan 30, 2026
Contributor
murphyjacob4
left a comment
murphyjacob4
left a comment
There was a problem hiding this comment.
Thanks @enjoy-binbin, seems like a very reasonable improvement
immangat
pushed a commit
to immangat/valkey
that referenced
this pull request
Feb 1, 2026
…alkey-io#2948) In dual channel replication, when the replica abort the replication, if the local buffer is huge, free it in async way to avoid the latency. Dual channel replication was introduced in valkey-io#60. Signed-off-by: Binbin <[email protected]>
harrylin98
pushed a commit
to harrylin98/valkey_forked
that referenced
this pull request
Feb 19, 2026
…alkey-io#2948) In dual channel replication, when the replica abort the replication, if the local buffer is huge, free it in async way to avoid the latency. Dual channel replication was introduced in valkey-io#60. Signed-off-by: Binbin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dual channel replication, when the replica abort the replication,
if the local buffer is huge, free it in async way to avoid the latency.
Dual channel replication was introduced in #60.