Skip to content

Backport: Fix potential infinite loop in clusterNodeGetMaster#2830

Merged
rjd15372 merged 1 commit intovalkey-io:7.2from
hieu2102:7.2
Nov 13, 2025
Merged

Backport: Fix potential infinite loop in clusterNodeGetMaster#2830
rjd15372 merged 1 commit intovalkey-io:7.2from
hieu2102:7.2

Conversation

@hieu2102
Copy link
Contributor

Issue #609 is marked as completed (fixed by #651); however, the fix is only present in versions 8.0 and above.

This PR backports the fix into the 7.2 branch

@rjd15372
Copy link
Member

@hieu2102 thanks for the backport. Can you change the PR title to:

backport: Fix potential infinite loop in clusterNodeGetPrimary

@rjd15372 rjd15372 requested a review from PingXie November 12, 2025 08:51
@rjd15372 rjd15372 added the bug Something isn't working label Nov 12, 2025
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (97b6663) to head (4cf0011).
⚠️ Report is 1 commits behind head on 7.2.

Additional details and impacted files
@@     Coverage Diff     @@
##   7.2   #2830   +/-   ##
===========================
===========================
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hieu2102 hieu2102 changed the title Backport #651 to the 7.2 branch Backport: Fix potential infinite loop in clusterNodeGetMaster Nov 12, 2025
@hieu2102
Copy link
Contributor Author

@rjd15372 I changed the title to clusterNodeGetMaster, as 7.2 still uses the old master/slave terminology.

Copy link
Member

@JimB123 JimB123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good.

Note that the test failures for defrag are unrelated. These are the old (7.2) defrag tests, before stability improvements.

@rjd15372 rjd15372 merged commit 4207301 into valkey-io:7.2 Nov 13, 2025
46 of 59 checks passed
@github-project-automation github-project-automation bot moved this to To be backported in Valkey 7.2 Nov 13, 2025
@zuiderkwast zuiderkwast moved this from To be backported to Done in Valkey 7.2 Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants