Backport: Fix potential infinite loop in clusterNodeGetMaster#2830
Merged
rjd15372 merged 1 commit intovalkey-io:7.2from Nov 13, 2025
Merged
Backport: Fix potential infinite loop in clusterNodeGetMaster#2830rjd15372 merged 1 commit intovalkey-io:7.2from
rjd15372 merged 1 commit intovalkey-io:7.2from
Conversation
Signed-off-by: hieu2102 <[email protected]>
Member
|
@hieu2102 thanks for the backport. Can you change the PR title to: backport: Fix potential infinite loop in clusterNodeGetPrimary |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 7.2 #2830 +/- ##
===========================
===========================
🚀 New features to boost your workflow:
|
Contributor
Author
|
@rjd15372 I changed the title to |
zuiderkwast
approved these changes
Nov 12, 2025
JimB123
approved these changes
Nov 12, 2025
Member
JimB123
left a comment
There was a problem hiding this comment.
Change looks good.
Note that the test failures for defrag are unrelated. These are the old (7.2) defrag tests, before stability improvements.
rjd15372
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #609 is marked as completed (fixed by #651); however, the fix is only present in versions 8.0 and above.
This PR backports the fix into the 7.2 branch