Update dual channel replication conf to mention the local buffer is imited by COB#2824
Merged
enjoy-binbin merged 2 commits intovalkey-io:unstablefrom Nov 23, 2025
Merged
Conversation
…imited by COB After introducing the dual channel replication in valkey-io#60, we decided in valkey-io#915 not to add a new configuration item to limit the replica's local replication buffer, just use "client-output-buffer-limit replica hard" to limit it. We need to document this behavior and mention that once the limit is reached, all future data will accumulate in the primary side. Signed-off-by: Binbin <[email protected]>
Signed-off-by: Binbin <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #2824 +/- ##
============================================
- Coverage 72.47% 72.44% -0.03%
============================================
Files 128 128
Lines 70286 70300 +14
============================================
- Hits 50937 50930 -7
- Misses 19349 19370 +21
🚀 New features to boost your workflow:
|
JimB123
approved these changes
Nov 13, 2025
Member
JimB123
left a comment
JimB123
left a comment
There was a problem hiding this comment.
Looks like a good documentation and logging change.
zuiderkwast
approved these changes
Nov 16, 2025
Contributor
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
Is dual-channel replication documented in any other place than in the template config file?
I don't think the config comments is the best place to put a lot of documentation. I think we need dual channel replication docs in the doc repo in topics/replication.md.
Member
Author
I don't think so. @naglera do we have a dual channel replication doc in the valkey-doc repo? It seems we didn't write it?
We can document it in two places. One is complex and detailed, and the other is simple (which can be redirected to the complex one). As far as I know, very few people actually read the documentation, and many don't even look at the valkey.conf configuration file. |
zhijun42
pushed a commit
to zhijun42/valkey
that referenced
this pull request
Nov 28, 2025
…mited by COB (valkey-io#2824) After introducing the dual channel replication in valkey-io#60, we decided in valkey-io#915 not to add a new configuration item to limit the replica's local replication buffer, just use "client-output-buffer-limit replica hard" to limit it. We need to document this behavior and mention that once the limit is reached, all future data will accumulate in the primary side. Signed-off-by: Binbin <[email protected]>
zhijun42
pushed a commit
to zhijun42/valkey
that referenced
this pull request
Nov 28, 2025
…mited by COB (valkey-io#2824) After introducing the dual channel replication in valkey-io#60, we decided in valkey-io#915 not to add a new configuration item to limit the replica's local replication buffer, just use "client-output-buffer-limit replica hard" to limit it. We need to document this behavior and mention that once the limit is reached, all future data will accumulate in the primary side. Signed-off-by: Binbin <[email protected]>
zhijun42
pushed a commit
to zhijun42/valkey
that referenced
this pull request
Nov 28, 2025
…mited by COB (valkey-io#2824) After introducing the dual channel replication in valkey-io#60, we decided in valkey-io#915 not to add a new configuration item to limit the replica's local replication buffer, just use "client-output-buffer-limit replica hard" to limit it. We need to document this behavior and mention that once the limit is reached, all future data will accumulate in the primary side. Signed-off-by: Binbin <[email protected]>
aradz44
pushed a commit
to aradz44/valkey
that referenced
this pull request
Dec 23, 2025
…mited by COB (valkey-io#2824) After introducing the dual channel replication in valkey-io#60, we decided in valkey-io#915 not to add a new configuration item to limit the replica's local replication buffer, just use "client-output-buffer-limit replica hard" to limit it. We need to document this behavior and mention that once the limit is reached, all future data will accumulate in the primary side. Signed-off-by: Binbin <[email protected]>
jjuleslasarte
pushed a commit
to jjuleslasarte/valkey
that referenced
this pull request
Jan 6, 2026
…mited by COB (valkey-io#2824) After introducing the dual channel replication in valkey-io#60, we decided in valkey-io#915 not to add a new configuration item to limit the replica's local replication buffer, just use "client-output-buffer-limit replica hard" to limit it. We need to document this behavior and mention that once the limit is reached, all future data will accumulate in the primary side. Signed-off-by: Binbin <[email protected]> Signed-off-by: jjuleslasarte <[email protected]>
jjuleslasarte
pushed a commit
to jjuleslasarte/valkey
that referenced
this pull request
Jan 6, 2026
…mited by COB (valkey-io#2824) After introducing the dual channel replication in valkey-io#60, we decided in valkey-io#915 not to add a new configuration item to limit the replica's local replication buffer, just use "client-output-buffer-limit replica hard" to limit it. We need to document this behavior and mention that once the limit is reached, all future data will accumulate in the primary side. Signed-off-by: Binbin <[email protected]> Signed-off-by: jjuleslasarte <[email protected]>
jdheyburn
pushed a commit
to jdheyburn/valkey
that referenced
this pull request
Jan 8, 2026
…mited by COB (valkey-io#2824) After introducing the dual channel replication in valkey-io#60, we decided in valkey-io#915 not to add a new configuration item to limit the replica's local replication buffer, just use "client-output-buffer-limit replica hard" to limit it. We need to document this behavior and mention that once the limit is reached, all future data will accumulate in the primary side. Signed-off-by: Binbin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After introducing the dual channel replication in #60, we decided in #915
not to add a new configuration item to limit the replica's local replication
buffer, just use "client-output-buffer-limit replica hard" to limit it.
We need to document this behavior and mention that once the limit is reached,
all future data will accumulate in the primary side.