Fix out-of-bound memory access when num-fields is not provided#2464
Merged
ranshid merged 1 commit intovalkey-io:unstablefrom Aug 11, 2025
Merged
Conversation
Signed-off-by: Ran Shidlansik <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #2464 +/- ##
============================================
+ Coverage 71.57% 71.60% +0.02%
============================================
Files 125 125
Lines 69218 69213 -5
============================================
+ Hits 49545 49560 +15
+ Misses 19673 19653 -20
🚀 New features to boost your workflow:
|
enjoy-binbin
approved these changes
Aug 11, 2025
allenss-amazon
pushed a commit
to allenss-amazon/valkey-core
that referenced
this pull request
Aug 19, 2025
…y-io#2464) Following new API presented in valkey-io#2089, we might access out of bound memory in case of some illegal command input Signed-off-by: Ran Shidlansik <[email protected]>
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Oct 3, 2025
…y-io#2464) Following new API presented in valkey-io#2089, we might access out of bound memory in case of some illegal command input Signed-off-by: Ran Shidlansik <[email protected]> Signed-off-by: Harkrishn Patro <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following new API presented in #2089, we might access out of bound memory in case of some illegal command input