Fix check-rdb --stats crash with empty RDB#2382
Merged
enjoy-binbin merged 1 commit intovalkey-io:unstablefrom Aug 4, 2025
Merged
Fix check-rdb --stats crash with empty RDB#2382enjoy-binbin merged 1 commit intovalkey-io:unstablefrom
enjoy-binbin merged 1 commit intovalkey-io:unstablefrom
Conversation
There are two problems with initializing databases to 1: 1. db0 is used by default. After printing db0, we will additionally print db1 with no reason. 2. Based on 1, if the RDB is an empty RDB, check-rdb will crash. Because there is no key data, we don't have the chance to call tryExpandRdbStats, and then when printting db1, we will crash on rdbstate.stats. Intrudoced in valkey-io#1743. Signed-off-by: Binbin <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #2382 +/- ##
=========================================
Coverage 71.44% 71.44%
=========================================
Files 123 123
Lines 67139 67139
=========================================
Hits 47968 47968
Misses 19171 19171
🚀 New features to boost your workflow:
|
zuiderkwast
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two problems with initializing databases to 1:
db1 with no reason.
there is no key data, we don't have the chance to call tryExpandRdbStats,
and then when printting db1, we will crash on rdbstate.stats.
Introduced in #1743.