Unset the active_clients_file before new test is assigned#2339
Merged
hpatro merged 1 commit intovalkey-io:unstablefrom Jul 10, 2025
Merged
Unset the active_clients_file before new test is assigned#2339hpatro merged 1 commit intovalkey-io:unstablefrom
hpatro merged 1 commit intovalkey-io:unstablefrom
Conversation
Signed-off-by: Sarthak Aggarwal <[email protected]>
hpatro
approved these changes
Jul 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #2339 +/- ##
============================================
+ Coverage 71.44% 71.48% +0.04%
============================================
Files 123 123
Lines 67092 67094 +2
============================================
+ Hits 47932 47961 +29
+ Misses 19160 19133 -27 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the change #2276, there are some cases where the the active_clients_file is not set.
It is because when the test is done, we were unsetting the active_clients_file after the new task was assigned. Ideally we should unset it before that since the first task is assigned via
readystate.make testis consistently passing now.