Fix the incorrect stdout redirect logic#2225
Merged
enjoy-binbin merged 4 commits intovalkey-io:unstablefrom Jun 18, 2025
Merged
Fix the incorrect stdout redirect logic#2225enjoy-binbin merged 4 commits intovalkey-io:unstablefrom
enjoy-binbin merged 4 commits intovalkey-io:unstablefrom
Conversation
Signed-off-by: skyfirelee <[email protected]>
artikell
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #2225 +/- ##
============================================
+ Coverage 71.58% 71.63% +0.05%
============================================
Files 122 123 +1
Lines 66766 66801 +35
============================================
+ Hits 47794 47853 +59
+ Misses 18972 18948 -24
🚀 New features to boost your workflow:
|
enjoy-binbin
added
the
run-extra-tests
Signed-off-by: Binbin <[email protected]>
Member
|
I added a commit to do the exit(1), please check. At the same time, this commit is also meant to trigger the extra-ci |
Signed-off-by: skyfirelee <[email protected]>
Signed-off-by: skyfirelee <[email protected]>
ranshid
pushed a commit
to ranshid/valkey
that referenced
this pull request
Jun 18, 2025
…alkey-io#2225) Use the standard `dup2` to redirect `stdout` Closes valkey-io#2224 Follow-up of valkey-io#1743 Signed-off-by: skyfirelee <[email protected]> Signed-off-by: Binbin <[email protected]> Co-authored-by: Binbin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the standard
dup2to redirectstdoutCloses #2224
Follow-up of #1743