Fix unit tests for 32-bit builds#2124
Merged
zuiderkwast merged 3 commits intovalkey-io:unstablefrom May 23, 2025
Merged
Conversation
Signed-off-by: Viktor Söderqvist <[email protected]>
zuiderkwast
added
test-failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #2124 +/- ##
============================================
+ Coverage 71.21% 71.24% +0.03%
============================================
Files 122 122
Lines 66046 66046
============================================
+ Hits 47034 47057 +23
+ Misses 19012 18989 -23 🚀 New features to boost your workflow:
|
Signed-off-by: Viktor Söderqvist <[email protected]>
zuiderkwast
changed the title
zuiderkwast
removed
the
run-extra-tests
Signed-off-by: Viktor Söderqvist <[email protected]>
zuiderkwast
force-pushed
the
fix-object-unit-test-32-bit
branch
from
7a82bc5 to
3bc32c0
Compare
madolson
approved these changes
May 22, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix these two unit test failures in 32-bit builds:
In 32-bit mode, the reference-counted object struct (robj) is smaller so we can fit longer values in embedded strings. Test case introduced in #2087.
For the second error, I guess it's an overflow, but the failing check isn't important for the test case so removing it. Test case introduced in #2085.
Additional change: Run unit tests in 32-bit CI build job.