Fix CLUSTER RESET to use lazyfree-lazy-user-flush to do the lazyfree#1931
Fix CLUSTER RESET to use lazyfree-lazy-user-flush to do the lazyfree#1931hwware merged 1 commit intovalkey-io:unstablefrom
Conversation
We use lazyfree-lazy-user-flush in valkey-io#1190 but in valkey-io#1926 it was changed to use replica-lazy-flush wrongly. Signed-off-by: Binbin <[email protected]>
|
@hpatro I don't see this discussed? If we want to change it, the description in valkey.conf needs to be changed as well. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1931 +/- ##
============================================
+ Coverage 71.06% 71.09% +0.03%
============================================
Files 123 123
Lines 65704 65704
============================================
+ Hits 46692 46715 +23
+ Misses 19012 18989 -23
🚀 New features to boost your workflow:
|
PingXie
left a comment
PingXie
left a comment
There was a problem hiding this comment.
Good catch! Thanks @enjoy-binbin
hpatro
left a comment
hpatro
left a comment
There was a problem hiding this comment.
|
i am not sure about it. replicate use |
hmm, that works too I think. that being said, there should've been just one lazy_flush config imo. |
I have a vague preference for user flush since this is a user triggered action. But, I think either are OK. I honestly think we might consider merging user-flush and replication flush in the future. |
Let's do it in 9.0? |
…alkey-io#1931) We use lazyfree-lazy-user-flush in valkey-io#1190 but in valkey-io#1926 it was changed to use replica-lazy-flush wrongly. Signed-off-by: Binbin <[email protected]> Signed-off-by: Nitai Caro <[email protected]>
…alkey-io#1931) We use lazyfree-lazy-user-flush in valkey-io#1190 but in valkey-io#1926 it was changed to use replica-lazy-flush wrongly. Signed-off-by: Binbin <[email protected]>
…alkey-io#1931) We use lazyfree-lazy-user-flush in valkey-io#1190 but in valkey-io#1926 it was changed to use replica-lazy-flush wrongly. Signed-off-by: Binbin <[email protected]>
…alkey-io#1931) We use lazyfree-lazy-user-flush in valkey-io#1190 but in valkey-io#1926 it was changed to use replica-lazy-flush wrongly. Signed-off-by: Binbin <[email protected]> Signed-off-by: hwware <[email protected]>
5 participants
We use lazyfree-lazy-user-flush in #1190 but in #1926 it was changed to use replica-lazy-flush wrongly.