Kill RDB child process on CLUSTER RESET command#1926
Merged
hpatro merged 1 commit intovalkey-io:unstablefrom Apr 7, 2025
Merged
Kill RDB child process on CLUSTER RESET command#1926hpatro merged 1 commit intovalkey-io:unstablefrom
hpatro merged 1 commit intovalkey-io:unstablefrom
Conversation
Signed-off-by: Harkrishn Patro <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1926 +/- ##
============================================
+ Coverage 71.02% 71.05% +0.02%
============================================
Files 123 123
Lines 65683 65683
============================================
+ Hits 46653 46671 +18
+ Misses 19030 19012 -18
🚀 New features to boost your workflow:
|
enjoy-binbin
added a commit
to enjoy-binbin/valkey
that referenced
this pull request
Apr 8, 2025
We use lazyfree-lazy-user-flush in valkey-io#1190 but in valkey-io#1926 it was changed to use replica-lazy-flush wrongly. Signed-off-by: Binbin <[email protected]>
murphyjacob4
pushed a commit
to enjoy-binbin/valkey
that referenced
this pull request
Apr 13, 2025
Fixes: valkey-io#1925 Signed-off-by: Harkrishn Patro <[email protected]>
hwware
pushed a commit
that referenced
this pull request
Apr 17, 2025
…1931) We use lazyfree-lazy-user-flush in #1190 but in #1926 it was changed to use replica-lazy-flush wrongly. Signed-off-by: Binbin <[email protected]>
nitaicaro
pushed a commit
to nitaicaro/valkey
that referenced
this pull request
Apr 22, 2025
…alkey-io#1931) We use lazyfree-lazy-user-flush in valkey-io#1190 but in valkey-io#1926 it was changed to use replica-lazy-flush wrongly. Signed-off-by: Binbin <[email protected]> Signed-off-by: Nitai Caro <[email protected]>
nitaicaro
pushed a commit
to nitaicaro/valkey
that referenced
this pull request
Apr 22, 2025
…alkey-io#1931) We use lazyfree-lazy-user-flush in valkey-io#1190 but in valkey-io#1926 it was changed to use replica-lazy-flush wrongly. Signed-off-by: Binbin <[email protected]>
nitaicaro
pushed a commit
to nitaicaro/valkey
that referenced
this pull request
Apr 22, 2025
…alkey-io#1931) We use lazyfree-lazy-user-flush in valkey-io#1190 but in valkey-io#1926 it was changed to use replica-lazy-flush wrongly. Signed-off-by: Binbin <[email protected]>
hwware
pushed a commit
to wuranxx/valkey
that referenced
this pull request
Apr 24, 2025
…alkey-io#1931) We use lazyfree-lazy-user-flush in valkey-io#1190 but in valkey-io#1926 it was changed to use replica-lazy-flush wrongly. Signed-off-by: Binbin <[email protected]> Signed-off-by: hwware <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1925