Pass null-terminated node ID for VM_RegisterClusterMessageReceiver and add test coverage#1708
Merged
zuiderkwast merged 12 commits intovalkey-io:unstablefrom Feb 20, 2025
Conversation
Signed-off-by: Nikhil Manglore <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1708 +/- ##
============================================
+ Coverage 71.06% 71.14% +0.08%
============================================
Files 121 123 +2
Lines 65254 65534 +280
============================================
+ Hits 46371 46627 +256
- Misses 18883 18907 +24
|
Member
Author
|
Looking into the CI Failure |
…nctionality Signed-off-by: Nikhil Manglore <[email protected]>
Signed-off-by: Nikhil Manglore <[email protected]>
hpatro
reviewed
Feb 11, 2025
Signed-off-by: Nikhil Manglore <[email protected]>
hpatro
reviewed
Feb 12, 2025
Signed-off-by: Nikhil Manglore <[email protected]>
Signed-off-by: Nikhil Manglore <[email protected]>
hpatro
reviewed
Feb 14, 2025
Signed-off-by: Nikhil Manglore <[email protected]>
Signed-off-by: Nikhil Manglore <[email protected]>
hpatro
approved these changes
Feb 17, 2025
Nikhil-Manglore
changed the title
Nikhil-Manglore
changed the title
Signed-off-by: Nikhil Manglore <[email protected]>
hpatro
changed the title
VM_RegisterClusterMessageReceiver and add test coverage
hpatro
reviewed
Feb 19, 2025
Signed-off-by: Nikhil Manglore <[email protected]>
zuiderkwast
reviewed
Feb 19, 2025
zuiderkwast
reviewed
Feb 19, 2025
Contributor
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
Yeah, just some nits, then let's merge it.
Signed-off-by: Nikhil Manglore <[email protected]>
Signed-off-by: Nikhil Manglore <[email protected]>
zuiderkwast
approved these changes
Feb 19, 2025
madolson
reviewed
Feb 21, 2025
zuiderkwast
pushed a commit
that referenced
this pull request
Mar 18, 2025
…and add test coverage (#1708) * Pass `sender_id` as `NULL` terminated string as part of `ValkeyModuleClusterMessageReceiver` for ease of usage by the module(s). * Implement test coverage described in #1656 and ensures that nodes in the cluster module properly acknowledge a "DING" message by sending a "DONG" response. Closes #1656. --------- Signed-off-by: Nikhil Manglore <[email protected]>
xbasel
pushed a commit
to xbasel/valkey
that referenced
this pull request
Mar 27, 2025
…and add test coverage (valkey-io#1708) * Pass `sender_id` as `NULL` terminated string as part of `ValkeyModuleClusterMessageReceiver` for ease of usage by the module(s). * Implement test coverage described in valkey-io#1656 and ensures that nodes in the cluster module properly acknowledge a "DING" message by sending a "DONG" response. Closes valkey-io#1656. --------- Signed-off-by: Nikhil Manglore <[email protected]>
xbasel
pushed a commit
to xbasel/valkey
that referenced
this pull request
Mar 27, 2025
…and add test coverage (valkey-io#1708) * Pass `sender_id` as `NULL` terminated string as part of `ValkeyModuleClusterMessageReceiver` for ease of usage by the module(s). * Implement test coverage described in valkey-io#1656 and ensures that nodes in the cluster module properly acknowledge a "DING" message by sending a "DONG" response. Closes valkey-io#1656. --------- Signed-off-by: Nikhil Manglore <[email protected]>
murphyjacob4
pushed a commit
to enjoy-binbin/valkey
that referenced
this pull request
Apr 13, 2025
…and add test coverage (valkey-io#1708) * Pass `sender_id` as `NULL` terminated string as part of `ValkeyModuleClusterMessageReceiver` for ease of usage by the module(s). * Implement test coverage described in valkey-io#1656 and ensures that nodes in the cluster module properly acknowledge a "DING" message by sending a "DONG" response. Closes valkey-io#1656. --------- Signed-off-by: Nikhil Manglore <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass
sender_idasNULLterminated string as part ofValkeyModuleClusterMessageReceiverfor ease of usage by the module(s).Implement test coverage described in Add test coverage for module callback registration for cluster message via
VM_RegisterClusterMessageReceiver#1656 and ensures that nodes in the cluster module properly acknowledge a "DING" message by sending a "DONG" response.Closes #1656.