Update comments and log message in cluster_legacy.c#1561
Merged
enjoy-binbin merged 2 commits intovalkey-io:unstablefrom Jan 17, 2025
Merged
Update comments and log message in cluster_legacy.c#1561enjoy-binbin merged 2 commits intovalkey-io:unstablefrom
enjoy-binbin merged 2 commits intovalkey-io:unstablefrom
Conversation
Signed-off-by: Pierre Turin <[email protected]>
Contributor
Author
|
@PingXie, could you take a look please? This should address the last comments you had in my previous PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1561 +/- ##
============================================
+ Coverage 70.78% 71.00% +0.21%
============================================
Files 120 121 +1
Lines 65046 65130 +84
============================================
+ Hits 46045 46245 +200
+ Misses 19001 18885 -116
|
PingXie
approved these changes
Jan 16, 2025
Signed-off-by: Pierre Turin <[email protected]>
pieturin
force-pushed
the
cluster-handshake-followup
branch
from
2957a38 to
28653a3
Compare
enjoy-binbin
approved these changes
Jan 17, 2025
proost
pushed a commit
to proost/valkey
that referenced
this pull request
Jan 17, 2025
Update comments and log message in `cluster_legacy.c`. Follow-up from valkey-io#1441. Signed-off-by: Pierre Turin <[email protected]> Co-authored-by: Ping Xie <[email protected]> Co-authored-by: Binbin <[email protected]> Signed-off-by: proost <[email protected]>
kronwerk
pushed a commit
to kronwerk/valkey
that referenced
this pull request
Jan 27, 2025
Update comments and log message in `cluster_legacy.c`. Follow-up from valkey-io#1441. Signed-off-by: Pierre Turin <[email protected]> Co-authored-by: Ping Xie <[email protected]> Co-authored-by: Binbin <[email protected]>
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Feb 1, 2025
Update comments and log message in `cluster_legacy.c`. Follow-up from valkey-io#1441. Signed-off-by: Pierre Turin <[email protected]> Co-authored-by: Ping Xie <[email protected]> Co-authored-by: Binbin <[email protected]> Signed-off-by: Harkrishn Patro <[email protected]>
enjoy-binbin
added a commit
to enjoy-binbin/valkey
that referenced
this pull request
Feb 2, 2025
Update comments and log message in `cluster_legacy.c`. Follow-up from valkey-io#1441. Signed-off-by: Pierre Turin <[email protected]> Co-authored-by: Ping Xie <[email protected]> Co-authored-by: Binbin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update comments and log message in
cluster_legacy.c.Follow-up from #1441.