Merged
Conversation
Signed-off-by: john vandenberg <[email protected]>
Contributor
Author
|
@zuiderkwast this ignores most of the latest batch. Many of these could be updated in the source to use more clear names that would avoid the extra whitelisting, but I've only fixed the clear spelling mistakes. |
Contributor
|
Can we pin it to a specific version, so things don't start to break whenever there is a new version? |
Contributor
Author
|
Yes, you can change https://github.com/valkey-io/valkey/blob/unstable/.github/workflows/spell-check.yml#L22 to be a specific version of the action, like https://github.com/taiki-e/install-action/releases/tag/v2.32.2 , and it will be more stable |
PatrickJS
pushed a commit
to PatrickJS/placeholderkv
that referenced
this pull request
Apr 24, 2024
Signed-off-by: john vandenberg <[email protected]> Co-authored-by: john vandenberg <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.