Handle keyIsExpiredWithDictIndex to make it check for import mode#1368
Conversation
In valkey-io#1326 we make KEYS can visit expired key in import-source state by updating keyIsExpired to check for import mode. But after valkey-io#1205, we now use keyIsExpiredWithDictIndex to optimize and remove the redundant dict_index, and keyIsExpiredWithDictIndex does not handle this logic. In this commit, we handle keyIsExpiredWithDictIndex to make it check for import mode as well so that KEYS can visit the expired key. Signed-off-by: Binbin <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1368 +/- ##
============================================
+ Coverage 70.57% 70.75% +0.17%
============================================
Files 117 117
Lines 63320 63324 +4
============================================
+ Hits 44690 44802 +112
+ Misses 18630 18522 -108
|
|
This one introduced some problem. :) Hopefully we just need a simple wait or something.
|
|
The problem is introduced in 1326. And this pr is fixing it. See top comment for the background |
|
Ah, sorry. So next daily will pass for sure. 😁 |
3 participants
In #1326 we make KEYS can visit expired key in import-source state
by updating keyIsExpired to check for import mode. But after #1205,
we now use keyIsExpiredWithDictIndex to optimize and remove the
redundant dict_index, and keyIsExpiredWithDictIndex does not handle
this logic.
In this commit, we handle keyIsExpiredWithDictIndex to make it check
for import mode as well so that KEYS can visit the expired key.