Remove redundant dict_index calculations#1205
Merged
madolson merged 3 commits intovalkey-io:unstablefrom Nov 22, 2024
Merged
Conversation
Signed-off-by: Nadav Levanoni <[email protected]>
Signed-off-by: Nadav Levanoni <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1205 +/- ##
============================================
+ Coverage 70.71% 70.72% +0.01%
============================================
Files 114 114
Lines 63090 63091 +1
============================================
+ Hits 44616 44624 +8
+ Misses 18474 18467 -7
|
Contributor
Author
|
Will add a follow-up PR for keys and scan commands. The impact will be greater because they do not cache the slot in the client. |
Signed-off-by: Nadav Levanoni <[email protected]>
nadav-levanoni
changed the title
Contributor
Author
|
I added the keysCommand optimization here. I had a cursory look at the scan command, and it might be trickier to find an optimization there. |
Contributor
Author
|
Commenting for attention |
Member
I'm sorry I'm slow :P |
madolson
approved these changes
Nov 22, 2024
enjoy-binbin
added a commit
to enjoy-binbin/valkey
that referenced
this pull request
Nov 27, 2024
In valkey-io#1326 we make KEYS can visit expired key in import-source state by updating keyIsExpired to check for import mode. But after valkey-io#1205, we now use keyIsExpiredWithDictIndex to optimize and remove the redundant dict_index, and keyIsExpiredWithDictIndex does not handle this logic. In this commit, we handle keyIsExpiredWithDictIndex to make it check for import mode as well so that KEYS can visit the expired key. Signed-off-by: Binbin <[email protected]>
enjoy-binbin
added a commit
that referenced
this pull request
Nov 28, 2024
) In #1326 we make KEYS can visit expired key in import-source state by updating keyIsExpired to check for import mode. But after #1205, we now use keyIsExpiredWithDictIndex to optimize and remove the redundant dict_index, and keyIsExpiredWithDictIndex does not handle this logic. In this commit, we handle keyIsExpiredWithDictIndex to make it check for import mode as well so that KEYS can visit the expired key. Signed-off-by: Binbin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to start making use of the new
WithDictIndexAPIs which allow us to reuse the dict_index calculation (avoid over-callinggetKeySlotfor no good reason).In this PR I optimized
lookupKeyso it now callsgetKeySlotto reuse the dict_index two additional times.The benefit here is reduced if the slot is cached in the client, which is generally the case.