Trigger the election as soon as possible when doing a forced manual failover#1067
Merged
enjoy-binbin merged 1 commit intovalkey-io:unstablefrom Sep 25, 2024
Merged
Conversation
…ailover In CLUSTER FAILOVER FORCE case, we will set mf_can_start to 1 and wait for a cron to trigger the election. We can also set a CLUSTER_TODO_HANDLE_MANUALFAILOVER flag so that we can start the election as soon as possible instead of waiting for the cron, so that we won't have a 100ms delay (clusterCron). Signed-off-by: Binbin <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #1067 +/- ##
============================================
+ Coverage 70.60% 70.64% +0.03%
============================================
Files 114 114
Lines 61677 61678 +1
============================================
+ Hits 43550 43571 +21
+ Misses 18127 18107 -20
🚀 New features to boost your workflow:
|
enjoy-binbin
added
the
release-notes
naglera
pushed a commit
to naglera/placeholderkv
that referenced
this pull request
Oct 10, 2024
…ailover (valkey-io#1067) In CLUSTER FAILOVER FORCE case, we will set mf_can_start to 1 and wait for a cron to trigger the election. We can also set a CLUSTER_TODO_HANDLE_MANUALFAILOVER flag so that we can start the election as soon as possible instead of waiting for the cron, so that we won't have a 100ms delay (clusterCron). Signed-off-by: Binbin <[email protected]> Signed-off-by: naglera <[email protected]>
enjoy-binbin
added a commit
to vitarb/valkey
that referenced
this pull request
Jun 17, 2025
…ailover (valkey-io#1067) In CLUSTER FAILOVER FORCE case, we will set mf_can_start to 1 and wait for a cron to trigger the election. We can also set a CLUSTER_TODO_HANDLE_MANUALFAILOVER flag so that we can start the election as soon as possible instead of waiting for the cron, so that we won't have a 100ms delay (clusterCron). Signed-off-by: Binbin <[email protected]>
Merged
zuiderkwast
pushed a commit
to vitarb/valkey
that referenced
this pull request
Aug 15, 2025
…ailover (valkey-io#1067) In CLUSTER FAILOVER FORCE case, we will set mf_can_start to 1 and wait for a cron to trigger the election. We can also set a CLUSTER_TODO_HANDLE_MANUALFAILOVER flag so that we can start the election as soon as possible instead of waiting for the cron, so that we won't have a 100ms delay (clusterCron). Signed-off-by: Binbin <[email protected]>
zuiderkwast
pushed a commit
to vitarb/valkey
that referenced
this pull request
Aug 15, 2025
…ailover (valkey-io#1067) In CLUSTER FAILOVER FORCE case, we will set mf_can_start to 1 and wait for a cron to trigger the election. We can also set a CLUSTER_TODO_HANDLE_MANUALFAILOVER flag so that we can start the election as soon as possible instead of waiting for the cron, so that we won't have a 100ms delay (clusterCron). Signed-off-by: Binbin <[email protected]> Signed-off-by: Viktor Söderqvist <[email protected]>
zuiderkwast
pushed a commit
to vitarb/valkey
that referenced
this pull request
Aug 21, 2025
…ailover (valkey-io#1067) In CLUSTER FAILOVER FORCE case, we will set mf_can_start to 1 and wait for a cron to trigger the election. We can also set a CLUSTER_TODO_HANDLE_MANUALFAILOVER flag so that we can start the election as soon as possible instead of waiting for the cron, so that we won't have a 100ms delay (clusterCron). Signed-off-by: Binbin <[email protected]> Signed-off-by: Viktor Söderqvist <[email protected]>
zuiderkwast
pushed a commit
that referenced
this pull request
Aug 22, 2025
…ailover (#1067) In CLUSTER FAILOVER FORCE case, we will set mf_can_start to 1 and wait for a cron to trigger the election. We can also set a CLUSTER_TODO_HANDLE_MANUALFAILOVER flag so that we can start the election as soon as possible instead of waiting for the cron, so that we won't have a 100ms delay (clusterCron). Signed-off-by: Binbin <[email protected]> Signed-off-by: Viktor Söderqvist <[email protected]>
sarthakaggarwal97
pushed a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Sep 16, 2025
…ailover (valkey-io#1067) In CLUSTER FAILOVER FORCE case, we will set mf_can_start to 1 and wait for a cron to trigger the election. We can also set a CLUSTER_TODO_HANDLE_MANUALFAILOVER flag so that we can start the election as soon as possible instead of waiting for the cron, so that we won't have a 100ms delay (clusterCron). Signed-off-by: Binbin <[email protected]> Signed-off-by: Viktor Söderqvist <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CLUSTER FAILOVER FORCE case, we will set mf_can_start to
1 and wait for a cron to trigger the election. We can also set
a CLUSTER_TODO_HANDLE_MANUALFAILOVER flag so that we can start
the election as soon as possible instead of waiting for the cron,
so that we won't have a 100ms delay (clusterCron).