Retry when an async slotmap update fails #159
Merged
bjosv merged 4 commits intovalkey-io:mainfrom Jan 23, 2025
Merged
Conversation
…dates * clusterclient_async received a new flag --async-initial-update to enable usage of valkeyClusterAsyncConnect2, which avoids blocking initial slotmap update. * Use short timeout when scheduling processing of next command in clusterclient_async which allow the event engine to read from sockets to improve predictability in tests. Signed-off-by: Björn Svensson <[email protected]>
As described in cluster slots docs: "Clients may treat the empty string in the same way as NULL, that is the same endpoint it used to send the current command to" Signed-off-by: Björn Svensson <[email protected]>
Additionally two new tests are added to verify that the slotmap updates are retried until it succeeds. Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix to reattempt failing slotmap updates.
Additionally:
Handle empty and NULL addresses in
CLUSTER SLOTSresponses.As described in cluster slots docs:
Clients may treat the empty string in the same way as NULL, that is the same endpoint it used to send the current command toclusterclient_asyncreceived a new flag--async-initial-updateto enable usage ofvalkeyClusterAsyncConnect2, which avoids blocking initial slotmap update.Use short timeout when scheduling processing of next command in
clusterclient_asyncand allow the event engine to read from sockets before next command, which improves predictability in tests.Final change similar to Nordix/hiredis-cluster#252.