Skip to content

Comments

Fix Weather ep_weather_provider_google_script: use classname to get image ID that is now dynamic#4392

Merged
Amrsatrio merged 1 commit intovalinet:masterfrom
davids5:master
Jul 28, 2025
Merged

Fix Weather ep_weather_provider_google_script: use classname to get image ID that is now dynamic#4392
Amrsatrio merged 1 commit intovalinet:masterfrom
davids5:master

Conversation

@davids5
Copy link
Contributor

@davids5 davids5 commented Jun 20, 2025

Fixes Weather widget is broken (#1334)

Here is the release build

ep_weather_host.zip

@Galthariel
Copy link

This new DLL worked flawless. Not even need to clear widget local data but to make sure it was working I did clear and like I said...it's working. Tks a lot for pointing out the solution. No Explorer or Computer restart was needed.

@mmalloy0
Copy link

Ditto for me. this new DLL worked. I did clear the widget local data and I restarted ExplorerPatcher but did not restart my computer.

@pyrates999
Copy link

Because these values are dynamically generated by google, I don't think this change will work in the long run. Please correct me if I'm wrong though.

@davids5
Copy link
Contributor Author

davids5 commented Jul 9, 2025

@valinet Can this come in?

@dissonator dissonator mentioned this pull request Jul 12, 2025
3 tasks
@DeanosT50
Copy link

Sorted and working...

For those unsure like I was...

Disable weather and wait a few seconds.

Then replace the current dll in "c:\Program Files\ExplorerPatcher" and re-enable weather.

@TaylorFan01313
Copy link

Fixes Weather widget is broken (#1334)

Here is the release build

ep_weather_host.zip

hey this works great, thanks

@Wozmar
Copy link

Wozmar commented Jul 27, 2025

This new ep_weather_host.dll library worked flawlessly.
There was no need to even clear the widget's local data, just to make sure it worked.
There was no need to restart Explorer or the computer.
Thanks a lot for pointing out the solution to davids5.

@pyrates999
Copy link

If it works for you, it means the class name that has the weather data is YQ4gaf zr758c. If it isn't working for you, it means the class name YQ4gaf zr758c does not exist.

@Amrsatrio Amrsatrio merged commit c3c83ff into valinet:master Jul 28, 2025
1 check failed
@mikal-s
Copy link

mikal-s commented Aug 17, 2025

Fixes Weather widget is broken (#1334)

Here is the release build

ep_weather_host.zip

Thank you so much, weather widget is working fine now.

@bitaljus
Copy link

Thanks. Weather widget is now working.

@cjahn50
Copy link

cjahn50 commented Sep 1, 2025

Just an FYI... If you needed any more proof that this is a Google weather issue, note that today the graphics are different than they were yesterday and there is no graphic in the task bar - only a temp. The .dll works like charm in getting the widget to display, but it's up to Google to make it look like it should. And the last I checked, the Sun is round, not lumpy 😂

@dissonator
Copy link

Today, regardless of the icon settings, the display is as shown in the attachment. The weather icon has disappeared from the taskbar, as mentioned above. Inside the widget, there is again a gap (this has happened before and was resolved with an update), and all the information is shifted down.

Screenshot 2025-09-01 231332

@cjahn50
Copy link

cjahn50 commented Sep 1, 2025

Today, regardless of the icon settings, the display is as shown in the attachment. The weather icon has disappeared from the taskbar, as mentioned above. Inside the widget, there is again a gap (this has happened before and was resolved with an update), and all the information is shifted down.

Screenshot 2025-09-01 231332

Yep, that's what it looks like. Lumpy suns and all. 😂

@davids5
Copy link
Contributor Author

davids5 commented Sep 2, 2025

Looking at the source of the data https://www.google.com/search?q=weather it is what changed. There is a mapping in the EP weather dll to the icon set that will need to be revisited.

Because the lumpy sun and other graphics may not survive in the eye of public opinion, am of the mindset of waiting before changing the dll.

@lucvw1975
Copy link

Everything's working with the new dll, except, as stated above, only temperature is displayed and not the icon beside it. Changing the settings to display text next to the temperature works, but I don't want text (it's way too long to fit), but the icon.

I hope there will be a fix soon.

@cjahn50
Copy link

cjahn50 commented Sep 2, 2025

Looking at the source of the data https://www.google.com/search?q=weather it is what changed. There is a mapping in the EP weather dll to the icon set that will need to be revisited.

Because the lumpy sun and other graphics may not survive in the eye of public opinion, am of the mindset of waiting before changing the dll.

I would not change anything. This is clearly a Google 'design' choice. With your current .dll, the widget loads as it should and is stable. And, I agree with you, the life span of a lumpy sun is probably pretty short. 😂

@dissonator
Copy link

dissonator commented Sep 3, 2025

Because the lumpy sun and other graphics may not survive in the eye of public opinion, am of the mindset of waiting before changing the dll.

I would like to emphasize once again that the Microsoft icon pack is not applied through the ExplorerPatcher/Weather/Icon pack settings.
And of course, the absence of the weather icon in the tray is disappointing #4545 (comment)

@dissonator dissonator mentioned this pull request Sep 3, 2025
3 tasks
@Amrsatrio
Copy link
Collaborator

Amrsatrio commented Sep 5, 2025

Hi @davids5, I want to make a new release soon (before Tuesday) to fix a breaking bug with taskbar toolbars on latest 24H2 optional update and onwards. I'd say it's better to be consistent with Google by adding the lumpy sun rather than leaving the icon blank...

@dissonator
Copy link

@davids5 @Amrsatrio Today everything stopped working after "Clear weather widget local data."
Numerous different tricks and nothing helped to restore at least what was there.
As mentioned earlier, "Unable to load weather information."
It seems the widget can be buried...

@DeanosT50
Copy link

@davids5 @Amrsatrio Today everything stopped working after "Clear weather widget local data." Numerous different tricks and nothing helped to restore at least what was there. As mentioned earlier, "Unable to load weather information." It seems the widget can be buried...

Working 100% for me!
Even the wobbly sun came back in the taskbar widget after the last Windows update on Wednesday...

@dissonator
Copy link

dissonator commented Sep 12, 2025

Working 100% for me!

It worked for me today too.
The strip at the top of the widget has disappeared.
The taskbar icon still does not display.
It seems that Google has nothing to do at all.

@DeanosT50
Copy link

image

Many restarts the past few days.

I recon if you having issues, check for windows updates and see after than.

All worked after Wednesday for me, no problems....

@dissonator
Copy link

check for windows updates

This is not related at all (it's hard to even imagine a more pointless piece of advice).
There were no updates related to the People app.
There is no icon in the taskbar for anyone on my contact list.

Does anyone else besides DeanosT50 see the icon in the taskbar?

@DeanosT50
Copy link

DeanosT50 commented Sep 12, 2025

All I'm saying is that after the update, it all worked perfect again.

Just my observation. Sorry if 6ou think my advise is stupid and pointless but it is what it is!

Even the comment right above mine says it also working after that.

Maybe your mach9ine has issues, or just you...

@dissonator
Copy link

dissonator commented Sep 12, 2025

@Amrsatrio In my case, it doesn't help. The popup message on the widget icon says 'No Internet access'.
Yesterday, it behaved absolutely the same way and somehow today it fixed itself.
The same thing happened before the fix from @davids5 appeared.

@iG8R
Copy link

iG8R commented Sep 12, 2025

With the 22631.5335.68.2 build it doesn't work at all.

image

@DeanosT50
Copy link

HOW?

I have the same version as you, all worked 90% before Wednesday.

image

This is my current Windows version also.

Like I said, I'm no expert, but it all just works now.

@iG8R Maybe you need to do the DLL reload thing from the beginning of this thread and see if it helps you.
We all had the same "no connection" error till the DLL thing fixed that.

Worth a try.

@iG8R
Copy link

iG8R commented Sep 12, 2025

@DeanosT50
ep_weather_host.zip is the same as in the new 26100.4946.69.1 build and with it Weather works, but the icon in the System tray is empty.

@dissonator
Copy link

@DeanosT50 In the issues section, people usually write about problems, not their absence. What works for you at the moment may not work for others and vice versa.

@DeanosT50
Copy link

Don't know mate...

Sorry.

Maybe try remove EP totally reboot the machine and reinstall fresh...
That's what I would do.

@DeanosT50
Copy link

@DeanosT50 In the issues section, people usually write about problems, not their absence. What works for you at the moment may not work for others and vice versa.

Just trying to help...........

@dissonator
Copy link

dissonator commented Sep 12, 2025

@Amrsatrio The trick with rolling back to 22631.5335.68.2 and then updating to 26100.4946.69.1 worked.
The widget content loaded. Taskbar icon is still missing.
After "Clear weather widget local data" it still doesn't work.

@Amrsatrio
Copy link
Collaborator

Amrsatrio commented Sep 12, 2025

image I'm playing around with the icon grabbing now. Somehow it's returning zeroed out data. There's no need to test out further, I used Google Chrome with a fresh profile to test this out.

@DeanosT50
Copy link

Maybe I broke Google? 🤣🤣🤣

@Amrsatrio
Copy link
Collaborator

https://issues.chromium.org/issues/40461578

Might be a Chromium bug. ep_weather uses the built-in createImageBitmap function, and probably Google recently changed the weather icon to be an SVG instead of a raster PNG.

Don't worry I'll keep playing around to workaround this bug.

@Amrsatrio
Copy link
Collaborator

Amrsatrio commented Sep 12, 2025

image

Looks a bit jagged but better than nothing.

@DeanosT50
Copy link

https://issues.chromium.org/issues/40461578

Might be a Chromium bug. ep_weather uses the built-in createImageBitmap function, and probably Google recently changed the weather icon to be an SVG instead of a raster PNG.

Don't worry I'll keep playing around to workaround this bug.

Considering mine is all working, please shout if you need any files or logs or something that might help you get to the bottom of it sooner...

Happy to try help if I can...

@Amrsatrio
Copy link
Collaborator

Pushed a commit with the fix. A new prerelease is being built.

@dissonator
Copy link

@Amrsatrio 26100.4946.69.2 problem is solved

@cjahn50
Copy link

cjahn50 commented Sep 12, 2025

@Amrsatrio 26100.4946.69.2 problem is solved

Is this release available? I don't see it on the code page. And, FWIW, there's no icon for me either. Just the temp.

@Galthariel
Copy link

It's fixed. Icon is back and everything is working as it should now. Thank you

@pyrates999
Copy link

@Amrsatrio 26100.4946.69.2 problem is solved

Is this release available? I don't see it on the code page. And, FWIW, there's no icon for me either. Just the temp.

It's a pre-release.

@cjahn50
Copy link

cjahn50 commented Sep 12, 2025

@Amrsatrio 26100.4946.69.2 problem is solved

Is this release available? I don't see it on the code page. And, FWIW, there's no icon for me either. Just the temp.

It's a pre-release.

Thanks! I just reloaded mine and still no icon in the tray. I'll wait for your newest version to do anything else. At my age, a lumpy sun is better that no sun at all 😂

@Amrsatrio
Copy link
Collaborator

Why wait when you can grab 69.2 right now?

@iG8R
Copy link

iG8R commented Sep 12, 2025

@cjahn50
Copy link

cjahn50 commented Sep 12, 2025

@Amrsatrio 26100.4946.69.2 problem is solved

Is this release available? I don't see it on the code page. And, FWIW, there's no icon for me either. Just the temp.

I found the pre-release and installed it. So far, so good. All appears normal. And having a lumpy sun icon in the task bar makes me smile. 😁

@PhilBaz
Copy link

PhilBaz commented Sep 30, 2025

just went to windows 11 and installed EP....i needed this dll to get whether working properly.

@artofwalls
Copy link

Today, regardless of the icon settings, the display is as shown in the attachment. The weather icon has disappeared from the taskbar, as mentioned above. Inside the widget, there is again a gap (this has happened before and was resolved with an update), and all the information is shifted down.

Screenshot 2025-09-01 231332

That mysterious white bar on top of the widget seems to be the title bar of the window. It is appearing in my PC too but it appears in blue (my usual color for window title bars)

Captura de pantalla 2025-09-30 230959

@cjahn50
Copy link

cjahn50 commented Sep 30, 2025

Today, regardless of the icon settings, the display is as shown in the attachment. The weather icon has disappeared from the taskbar, as mentioned above. Inside the widget, there is again a gap (this has happened before and was resolved with an update), and all the information is shifted down.
Screenshot 2025-09-01 231332

That mysterious white bar on top of the widget seems to be the title bar of the window. It is appearing in my PC too but it appears in blue (my usual color for window title bars)

Captura de pantalla 2025-09-30 230959

What version of EP are you on.? I had the same issue(s) as you are experiencing. The pre-release version 26100.4946.69.2 fixed it for me.

And I am going by your description. I cannot see your screenshot.

@artofwalls
Copy link

Today, regardless of the icon settings, the display is as shown in the attachment. The weather icon has disappeared from the taskbar, as mentioned above. Inside the widget, there is again a gap (this has happened before and was resolved with an update), and all the information is shifted down.
Screenshot 2025-09-01 231332

That mysterious white bar on top of the widget seems to be the title bar of the window. It is appearing in my PC too but it appears in blue (my usual color for window title bars)
Captura de pantalla 2025-09-30 230959

What version of EP are you on.? I had the same issue(s) as you are experiencing. The pre-release version 26100.4946.69.2 fixed it for me.

And I am going by your description. I cannot see your screenshot.

I am on version 22631.5335.68.2
The link to the image is https://private-user-images.githubusercontent.com/18701653/495912009-c0788cca-9a13-406c-8666-f28e48eb0b1c.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTkyODY1MTAsIm5iZiI6MTc1OTI4NjIxMCwicGF0aCI6Ii8xODcwMTY1My80OTU5MTIwMDktYzA3ODhjY2EtOWExMy00MDZjLTg2NjYtZjI4ZTQ4ZWIwYjFjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTEwMDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMDAxVDAyMzY1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg1OWE5MWFhZjFkMzhmNDdiNWMxZGI2MzVjZDBlNGYyMTdlZWU2N2ZjZmU5Nzg5ZDdmYWY4NWY2YzdmNGQ1MjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0._2o6v3igMKRDCKL9n1MZRSN77pNIIx0Q94due_vNb_Y

@pyrates999
Copy link

Today, regardless of the icon settings, the display is as shown in the attachment. The weather icon has disappeared from the taskbar, as mentioned above. Inside the widget, there is again a gap (this has happened before and was resolved with an update), and all the information is shifted down.
Screenshot 2025-09-01 231332

That mysterious white bar on top of the widget seems to be the title bar of the window. It is appearing in my PC too but it appears in blue (my usual color for window title bars)
Captura de pantalla 2025-09-30 230959

What version of EP are you on.? I had the same issue(s) as you are experiencing. The pre-release version 26100.4946.69.2 fixed it for me.
And I am going by your description. I cannot see your screenshot.

I am on version 22631.5335.68.2 The link to the image is https://private-user-images.githubusercontent.com/18701653/495912009-c0788cca-9a13-406c-8666-f28e48eb0b1c.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTkyODY1MTAsIm5iZiI6MTc1OTI4NjIxMCwicGF0aCI6Ii8xODcwMTY1My80OTU5MTIwMDktYzA3ODhjY2EtOWExMy00MDZjLTg2NjYtZjI4ZTQ4ZWIwYjFjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTEwMDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMDAxVDAyMzY1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg1OWE5MWFhZjFkMzhmNDdiNWMxZGI2MzVjZDBlNGYyMTdlZWU2N2ZjZmU5Nzg5ZDdmYWY4NWY2YzdmNGQ1MjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0._2o6v3igMKRDCKL9n1MZRSN77pNIIx0Q94due_vNb_Y

Install the latest pre-release of EP from here: https://github.com/valinet/ExplorerPatcher/releases

It has the dll this pull request included.

@MaximoCocolio
Copy link

Hi, yesterday i have installed Windows 11 Enterprise on my desktop but sadly Weather is not working, i have replaced the given DLL but still don´t work, is there any solution?

Thanks

@pyrates999
Copy link

This is a pull request that has been closed.

see these 2 issues: #4536 and #1334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Weather widget is broken.