Skip to content

Conversation

@WikiRik
Copy link
Member

@WikiRik WikiRik commented Nov 4, 2022

This is a draft PR to fix #1272. @fpedroza can you confirm that this would enable support for IE again? If so, I will refactor the includes function to become one function that accepts both strings and arrays.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (531dc7f) to head (d5facae).
Report is 128 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2099   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       105    +1     
  Lines         2308      2317    +9     
  Branches       578       578           
=========================================
+ Hits          2308      2317    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fpedroza
Copy link

I certainly think these changes would address our concern. We use eslint to help ensure we are staying compliant with older browsers FWIW.

@WikiRik
Copy link
Member Author

WikiRik commented Nov 14, 2022

Can you share which rule/plugin you are using? Then I can add those locally to check

@fpedroza
Copy link

fpedroza commented Nov 15, 2022

.eslintrc.json

{
  "env": {
    "browser": true,
    "es6": false
  },
  "globals": {
    "define": true,
    "msieversion": true
  },
  "plugins": [ "es5" ],
  "extends": [ "plugin:es5/no-es2015" ],
  "parserOptions": { "sourceType": "module" },
  "rules": {
    "no-console": "error",
    "es5/no-block-scoping": "error",
    "es5/no-es6-methods": "warn"
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

String.prototype.includes() is not supported in IE

2 participants