Skip to content

feat(isPassportNumber, isIBAN, isMobilePhone): updated to validate Mozambique passport, Mobile and IBAN number; #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
profnandaa merged 8 commits into from
Apr 18, 2021
Merged

feat(isPassportNumber, isIBAN, isMobilePhone): updated to validate Mozambique passport, Mobile and IBAN number; #1604

profnandaa merged 8 commits into from
Apr 18, 2021

Conversation

@salmento
Copy link
Contributor

@salmento salmento commented Feb 12, 2021 •
edited
Loading

{{ feat(isPassportNumber) and feat(isMobilePhone): updated to validate Mozambique passport number and mobile phone }}

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Feb 12, 2021 •
edited
Loading

Codecov Report

Merging #1604 (de4f723) into master (05ceb18) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1604   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          100       100           
  Lines         1847      1847           
=========================================
  Hits          1847      1847
Impacted Files Coverage Δ
src/lib/isIBAN.js 100.00% <ø> (ø)
src/lib/isMobilePhone.js 100.00% <ø> (ø)
src/lib/isPassportNumber.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05ceb18...de4f723. Read the comment docs.

@renanmontebelo
Copy link
Contributor

renanmontebelo commented Feb 13, 2021

I believe you should remove /validator.js and /validator.min.js from the PR as those are auto-generated by npm test.

@profnandaa
Copy link
Member

profnandaa commented Feb 28, 2021

@salmento -- please fix the merge conflic and we should be good.

@tux-tn tux-tn added 🧹 needs-update For PRs that need to be updated before landing 🎉 first-pr labels Mar 1, 2021
tux-tn
tux-tn requested changes Mar 12, 2021
View reviewed changes
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salmento sorry we merged some other PRs, can you please fix the new conflicts?

@salmento
Copy link
Contributor Author

salmento commented Mar 12, 2021

@salmento sorry we merged some other PRs, can you please fix the new conflicts?

Sure!!

tux-tn
tux-tn previously approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You left a trailing space in README.md i removed it ! LGTM ! Thank you for the change and for your first PR 🎉

@tux-tn tux-tn added ready-to-land For PRs that are reviewed and ready to be landed and removed 🧹 needs-update For PRs that need to be updated before landing labels Mar 12, 2021
@salmento
Copy link
Contributor Author

salmento commented Mar 12, 2021

You left a trailing space in README.md i removed it ! LGTM ! Thank you for the change and for your first PR 🎉

Thanks

@salmento salmento dismissed stale reviews from kishannareshpal and tux-tn via 7647fff March 12, 2021 19:19
@salmento salmento changed the title feat(isPassportNumber): updated to validate Mozambique passport number; feat(isPassportNumber, isIBAN, isMobilePhone): updated to validate Mozambique passport, Mobile and IBAN number; Mar 12, 2021
@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Apr 17, 2021
@profnandaa
Copy link
Member

profnandaa commented Apr 17, 2021

Sorry, another merge conflict :(

@profnandaa profnandaa removed the ready-to-land For PRs that are reviewed and ready to be landed label Apr 17, 2021
@profnandaa profnandaa merged commit 3f70b8e into validatorjs:master Apr 18, 2021
@profnandaa profnandaa mentioned this pull request Apr 19, 2021
Closed
@breadadams breadadams mentioned this pull request Nov 20, 2023
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@profnandaa profnandaa profnandaa approved these changes

@tux-tn tux-tn tux-tn left review comments

+1 more reviewer

@kishannareshpal kishannareshpal kishannareshpal left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🎉 first-pr mc-to-land Just merge-conflict standing between the PR and landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@salmento @renanmontebelo @profnandaa @tux-tn @kishannareshpal