Skip to content

Conversation

@fedeci
Copy link
Contributor

@fedeci fedeci commented Feb 12, 2021

This PR adds other test cases for isSlug validator.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #1602 (bd85edc) into master (1b85829) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1602   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          100       100           
  Lines         1796      1793    -3     
=========================================
- Hits          1796      1793    -3     
Impacted Files Coverage Δ
src/lib/isDataURI.js 100.00% <100.00%> (ø)
src/lib/isMACAddress.js 100.00% <100.00%> (ø)
src/lib/isStrongPassword.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b85829...8f2df04. Read the comment docs.

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 thank you for your contrib @fedeci

@profnandaa profnandaa merged commit 328dea0 into validatorjs:master Mar 3, 2021
@fedeci fedeci deleted the add-slug-tests branch March 19, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants