fix: add base58 and fix bech32 for is btc address #1548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1548 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 99 99
Lines 1773 1776 +3
=========================================
+ Hits 1773 1776 +3
Continue to review full report at Codecov.
|
profnandaa
reviewed
Dec 9, 2020
| // supports Bech32 addresses | ||
| const btc = /^(bc1|[13])[a-zA-HJ-NP-Z0-9]{25,39}$/; | ||
| const bech32 = /^(bc1)[a-z0-9]{25,39}$/; | ||
| const base58 = /^(1|3)[A-HJ-NP-Za-km-z1-9]{25,39}$/; |
Member
There was a problem hiding this comment.
We have isBase58 validator, how about re-using it here?
Member
Author
There was a problem hiding this comment.
I only have an issue with the reuse since:
base58will only be needed onA-HJ-NP-Za-km-z1-9hence we will need to add(1|3)in front of it and check thatbase58 has 25-39 chars.
Based on the above, I realized it will be hard to read and maintain the code
Member
There was a problem hiding this comment.
I see, makes sense. I'm good then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1386
Checklist