Skip to content

Fix for isFQDN wth numeric domain names #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
profnandaa merged 2 commits into from
Dec 8, 2020
Merged

Fix for isFQDN wth numeric domain names #1546

profnandaa merged 2 commits into from
Dec 8, 2020

Conversation

@tux-tn
Copy link
Member

@tux-tn tux-tn commented Dec 4, 2020 •
edited by profnandaa
Loading

Hello

Checklist

  • PR contains only changes related; no stray files, etc.
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Dec 4, 2020 •
edited
Loading

Codecov Report

Merging #1546 (b35b1f8) into master (302d295) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1546   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           99        99           
  Lines         1773      1773           
=========================================
  Hits          1773      1773
Impacted Files Coverage Δ
src/lib/isFQDN.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 302d295...b35b1f8. Read the comment docs.

@CristhianMotoche CristhianMotoche mentioned this pull request Dec 5, 2020
Closed
@profnandaa
Copy link
Member

profnandaa commented Dec 8, 2020

Fixes #1543

profnandaa
profnandaa approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@profnandaa profnandaa merged commit 3358f45 into validatorjs:master Dec 8, 2020
This was referenced Dec 8, 2020
Closed
Closed
@niftylettuce
Copy link

niftylettuce commented Dec 8, 2020

Can we get a release out to npm? @profnandaa

@tux-tn tux-tn deleted the fix/isFQDN branch December 9, 2020 11:15
profnandaa added a commit that referenced this pull request Dec 10, 2020
@profnandaa
13.5.2
96afe43 
- patch fixing #1545 #1543 and #1544
- ref PR #1546 by @tux-tn
profnandaa added a commit that referenced this pull request Dec 10, 2020
@profnandaa
13.5.2
cff2b76 
- patch fixing #1545 #1543 and #1544
- ref PR #1546 by @tux-tn
profnandaa added a commit that referenced this pull request Dec 10, 2020
@profnandaa
13.5.2
b793beb 
- patch fixing #1545 #1543 and #1544
- ref PR #1546 by @tux-tn
@profnandaa
Copy link
Member

profnandaa commented Dec 10, 2020 •
edited
Loading

13.5.2 is now published on NPM as hotfix. Here is the hotfix branch too - hotfix/13.5.2.

/cc. @niftylettuce @andyli9449 @mbalaam - please let's know if all looks good.

@profnandaa profnandaa mentioned this pull request Apr 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@profnandaa profnandaa profnandaa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

isFQDN returns false for a valid FQDN

3 participants

@tux-tn @profnandaa @niftylettuce