-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Closed
Description
For my #890 PR, I intentionally left out isFloat since I noticed that it does not throw an error for "unsupported" locales but rather falls back on a default.
Should we add throwing an error now since that has been the pattern for the rest, or will we be risking backward incompatibility (before line 7)?
// check for unsupported locale
// for uniformity with other locale-based functions
if (options.locale && !decimal[options.locale]) {
throw new Error(`Invalid locale '${options.locale}'`);
}OR
Should we just export the locales alone isFloatLocales and leave everything as is?
Metadata
Metadata
Assignees
Labels
No labels