-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Closed
Labels
Description
Describe the bug
Properties of an object are considered undefined unless set, but an explicit undefined value is taken into consideration when determining if isInt or isFloat succeeds due to the use of hasOwnProperty.
Lines 18 to 21 in b958bd7
| let minCheckPassed = (!options.hasOwnProperty('min') || str >= options.min); | |
| let maxCheckPassed = (!options.hasOwnProperty('max') || str <= options.max); | |
| let ltCheckPassed = (!options.hasOwnProperty('lt') || str < options.lt); | |
| let gtCheckPassed = (!options.hasOwnProperty('gt') || str > options.gt); |
Examples
import { isInt } from 'validator'
isInt("5") // => true
isInt("5", {min: 0, max: 10}) // => true
isInt("5", { }} // => true
isInt("5", {min: undefined, max: undefined}) // => falseMaybe it's just my opinion, but I think that last one should also return true.
Additional context
Validator.js version: [email protected]
Node.js version: Node 18.17.1
OS platform: linux