fix: remove errors from the isIBAN validator

edilson · edilson · commit bd34c0b6ddf0 · 2023-07-24T14:30:15.000-03:00
diff --git a/src/lib/isIBAN.js b/src/lib/isIBAN.js
@@ -126,21 +126,21 @@ function hasValidIbanFormat(str, options) {
 
   if (options.whitelist) {
     if (!hasOnlyValidCountryCodes(options.whitelist)) {
-      throw new Error('One of the codes passed is invalid');
+      return false;
     }
 
     const isoCountryCodeInWhiteList = options.whitelist.includes(isoCountryCode);
 
     if (!isoCountryCodeInWhiteList) {
-      throw new Error('IBAN code does not belong to one of the countries listed on whitelist!');
+      return false;
     }
   }
 
   if (options.blacklist) {
     const isoCountryCodeInBlackList = options.blacklist.includes(isoCountryCode);
 
     if (isoCountryCodeInBlackList) {
-      throw new Error('IBAN code belongs to one of the countries listed on blacklist!');
+      return false;
     }
   }
 
diff --git a/test/validators.test.js b/test/validators.test.js
@@ -5257,7 +5257,7 @@ describe('Validators', () => {
         'DK5000400440116243',
         'GB29NWBK60161331926819',
       ],
-      error: [
+      invalid: [
         'BE71 0961 2345 6769',
         'FR76 3000 6000 0112 3456 7890 189',
         'DE91 1000 0000 0123 4567 89',
@@ -5275,7 +5275,7 @@ describe('Validators', () => {
     test({
       validator: 'isIBAN',
       args: [{ whitelist: ['XX', 'AA'] }],
-      error: [
+      invalid: [
         'DK5000400440116243',
         'GB29NWBK60161331926819',
         'BE71 0961 2345 6769',
@@ -5318,15 +5318,13 @@ describe('Validators', () => {
         'IR200170000000339545727003',
         'MZ97123412341234123412341',
       ],
-      error: [
-        'IT60X0542811101000000123456',
-      ],
       invalid: [
         'XX22YYY1234567890123',
         'FR14 2004 1010 0505 0001 3',
         'FR7630006000011234567890189@',
         'FR7630006000011234567890189😅',
         'FR763000600001123456!!🤨7890189@',
+        'IT60X0542811101000000123456',
       ],
     });
   });

Original file line number	Diff line number	Diff line change
`@@ -126,21 +126,21 @@ function hasValidIbanFormat(str, options) {`
`126`	`126`
`127`	`127`	`if (options.whitelist) {`
`128`	`128`	`if (!hasOnlyValidCountryCodes(options.whitelist)) {`
`129`		`- throw new Error('One of the codes passed is invalid');`
	`129`	`+ return false;`
`130`	`130`	`}`
`131`	`131`
`132`	`132`	`const isoCountryCodeInWhiteList = options.whitelist.includes(isoCountryCode);`
`133`	`133`
`134`	`134`	`if (!isoCountryCodeInWhiteList) {`
`135`		`- throw new Error('IBAN code does not belong to one of the countries listed on whitelist!');`
	`135`	`+ return false;`
`136`	`136`	`}`
`137`	`137`	`}`
`138`	`138`
`139`	`139`	`if (options.blacklist) {`
`140`	`140`	`const isoCountryCodeInBlackList = options.blacklist.includes(isoCountryCode);`
`141`	`141`
`142`	`142`	`if (isoCountryCodeInBlackList) {`
`143`		`- throw new Error('IBAN code belongs to one of the countries listed on blacklist!');`
	`143`	`+ return false;`
`144`	`144`	`}`
`145`	`145`	`}`
`146`	`146`