Conversation
Summary by CodeRabbit
WalkthroughAdds StaticHolidays support to Gabon, introduces GabonStaticHolidays with year-specific public holidays (2024–2025), restructures holiday population (new Renovation Day, Easter Sunday, Youth Day, Whit Sunday/Monday, Liberation Day, conditional Independence variants), extends Islamic confirmed-year ranges, and updates locales, tests, and snapshots. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3317 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 308 308
Lines 18483 18499 +16
Branches 2369 2374 +5
=========================================
+ Hits 18483 18499 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/countries/test_gabon.py (1)
156-166:⚠️ Potential issue | 🟠 MajorUse the non-estimated Eid helper for the explicit dates too.
These two tests still spot-check the default holiday set with
assertHolidayName(...), then switch toassertIslamicNoEstimatedHolidayName(...)for the range assertion. That mixes two different fixtures for the same Gabon Eid data and can miss regressions in the exact years you’re pinning here. UseassertIslamicNoEstimatedHolidayName(...)for the concrete dates as well.Based on learnings: For Gabon's holiday implementation (tests/countries/test_gabon.py), all Islamic holiday dates are currently estimates. Therefore, the correct test pattern is to use assertIslamicNoEstimatedHolidayName for both specific known dates and the full range.Patch
def test_eid_al_fitr(self): name = "Fin du Ramadan" - self.assertHolidayName( + self.assertIslamicNoEstimatedHolidayName( name, "2021-05-13", "2022-05-02", "2023-04-21", "2024-04-10", "2025-03-30", ) self.assertIslamicNoEstimatedHolidayName(name, self.full_range) def test_eid_al_adha(self): name = "Fête du sacrifice" - self.assertHolidayName( + self.assertIslamicNoEstimatedHolidayName( name, "2021-07-20", "2022-07-09", "2023-06-28", "2024-06-16", "2025-06-06", ) self.assertIslamicNoEstimatedHolidayName(name, self.full_range)Also applies to: 168-178
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/countries/test_gabon.py` around lines 156 - 166, In tests/countries/test_gabon.py, replace the use of assertHolidayName for the explicit Eid dates with assertIslamicNoEstimatedHolidayName so both the spot-checked dates and the full-range check use the non-estimated Islamic helper; update the calls in test_eid_al_fitr (the explicit date assertions currently calling assertHolidayName) and the similar block around the other Eid test (the second block noted) to call assertIslamicNoEstimatedHolidayName with the same date list and range variables.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@tests/countries/test_gabon.py`:
- Around line 156-166: In tests/countries/test_gabon.py, replace the use of
assertHolidayName for the explicit Eid dates with
assertIslamicNoEstimatedHolidayName so both the spot-checked dates and the
full-range check use the non-estimated Islamic helper; update the calls in
test_eid_al_fitr (the explicit date assertions currently calling
assertHolidayName) and the similar block around the other Eid test (the second
block noted) to call assertIslamicNoEstimatedHolidayName with the same date list
and range variables.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 4d4da33e-eff2-4af6-9c34-7eb1992c8b73
📒 Files selected for processing (1)
tests/countries/test_gabon.py
3 participants
Proposed change
Update Gabon holidays (add historical and new holidays).
Type of change
holidaysfunctionality in general)Checklist
make checklocally; all checks and tests passed.