Update India holidays: add Telugu language support#3303
Update India holidays: add Telugu language support#3303arkid15r merged 3 commits intovacanza:devfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughAdds Telugu (te) localization for India: updates README and Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds Telugu (te) localization support for India holidays, aligning the India holiday entity’s supported languages, translations, tests, and documentation to resolve issue #3256.
Changes:
- Added full Telugu translation catalog for India holidays (
IN.po). - Registered
teas a supported language forIndiaholidays. - Added a localization test to assert the complete set of Telugu holiday names for 2018 (including subdivision-derived holidays).
- Updated README to list Telugu among India’s supported languages.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/countries/test_india.py |
Adds test_l10n_te to validate Telugu localization output across India + all subdivisions. |
holidays/locale/te/LC_MESSAGES/IN.po |
Introduces Telugu translations for all IN holiday msgids (100% coverage). |
holidays/countries/india.py |
Adds "te" to supported_languages for the India entity. |
README.md |
Updates India row to include te in supported languages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3303 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 307 307
Lines 18396 18460 +64
Branches 2354 2369 +15
=========================================
+ Hits 18396 18460 +64 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Implementation-wise, this is ready to merge.
However, I’ve noticed several spelling inconsistencies in the Telugu l10n compared to #3300 - It would be good to align these before merging.
@MounikaYerramsetti26 @Abiram08 Since I assumed you’re both Telugu speakers, could you please review and agree on the preferred spellings so we can standardise them?
|
Sure will look right into it. |
|
Proposed change
Added Telugu (te) localization for India holidays, resolving issue #3256.
Changes made:
holidays/locale/te/LC_MESSAGES/IN.powith Telugu translations (100% coverage)supported_languagesinholidays/countries/india.pyto includetetest_l10n_teintests/countries/test_india.pyto verify all Telugu translationsREADME.mdto reflect Telugu language supportType of change
holidaysfunctionality in general)Checklist
make checklocally; all checks and tests passed.