Update Kyrgyzstan holidays: add l10n support#3301
Merged
arkid15r merged 1 commit intovacanza:devfrom Feb 28, 2026
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (7)
Summary by CodeRabbit
WalkthroughThe PR refactors Kyrgyzstan's holiday implementation to use ObservedHolidayBase with modular holiday categories (Christian, International, Islamic, Static). It introduces structured Islamic holiday data, expanded observed-date handling, workday support, comprehensive localization for en_US/ky/ru_KG, updated snapshots, and extensive test coverage. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3301 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 307 307
Lines 18396 18455 +59
Branches 2354 2368 +14
=========================================
+ Hits 18396 18455 +59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Update Kyrgyzstan holidays: add l10n support (en_US, ky, ru_KG).
(Unfortunately, Wayback Machine cannot take snapshots of official source pages, and there are very few snapshots available).
Type of change
holidaysfunctionality in general)Checklist
make checklocally; all checks and tests passed.