Update South Korea holidays: add Constitution Day back for 2026 onwards#3284
Update South Korea holidays: add Constitution Day back for 2026 onwards#3284arkid15r merged 2 commits intovacanza:devfrom
Conversation
kawai10
requested review from
KJhellico,
PPsyrius and
arkid15r
as code owners
WalkthroughConstitution Day holiday support for South Korea is reactivated for 2026 onwards, after being disabled from 2008 to 2025. A contributor is added and corresponding tests are updated to validate the new holiday range. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Restores South Korea’s Constitution Day (제헌절, July 17) as a public holiday starting in 2026, aligning the KR holiday calendar with the referenced Act on Public Holidays update.
Changes:
- Update South Korea holiday generation logic to include Constitution Day again for years ≥ 2026.
- Adjust South Korea tests to validate the 2008–2025 gap and the 2026+ reinstatement.
- Add the contributor name and an additional legal reference link.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
holidays/countries/south_korea.py |
Reintroduces Constitution Day for years >= 2026 and adds a supporting legal reference. |
tests/countries/test_south_korea.py |
Updates assertions to expect no Constitution Day from 2008–2025 and to expect it again from 2026 onward. |
CONTRIBUTORS |
Adds the new contributor entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@holidays/countries/south_korea.py`:
- Around line 193-195: The code adds Constitution Day via
self._add_holiday_jul_17 for years >= 2026 but never calls append_observed so
substitute holidays aren't generated; modify the branch that handles self._year
>= 2026 to call self.append_observed on the July 17 holiday (use the same
holiday object or key returned/recorded by self._add_holiday_jul_17) so weekend
occurrences produce observed days, and update the module docstring to state that
제헌절 is a national holiday again from 2026 and that substitute holidays (대체공휴일)
apply starting 2027.
- Line 64: Update the archived law reference in south_korea.py: replace the
existing web.archive.org URL (the one with efYd=20220101&lsiSeq=233829) with the
archived link that points to the 2026-amended Act on Public Holidays (use the
efYd for the 2026 effective date, e.g. efYd=20260203, and the corresponding
lsiSeq for the 2026 amendment) so the archived page shows 제헌절 as a public
holiday; keep the same comment format and include the amendment date/notes so
the file documents when the holiday was added.
In `@tests/countries/test_south_korea.py`:
- Around line 353-358: The test_constitution_day test is missing assertions for
observed (substitute) holidays after the append_observed change in
south_korea.py; update the test_constitution_day function to assert that "제헌절 대체
휴일" (or f"{name} 대체 휴일") is present for dates where Constitution Day (July 17)
falls on a weekend from 2027 onward—generate expected substitute dates for those
years and add assertions using assertHolidayName for that range, while keeping
the existing base-date assertions intact.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3284 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 307 307
Lines 18373 18373
Branches 2352 2352
=========================================
Hits 18373 18373 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PPsyrius
left a comment
PPsyrius
left a comment
There was a problem hiding this comment.
Small suggestions, the rest of the PR looks pretty LGTM
PPsyrius
changed the title
- Replace Wayback Machine link with archive.today links for Public Holidays Act and National Day Act references - Merge separate assertHolidayName calls for Constitution Day into one Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
|
@kawai10 thanks for the contribution 👍 |
Proposed change
Restore Constitution Day (제헌절, July 17) as a public holiday in South Korea from 2026 onward.
Constitution Day was removed from the public holiday list in 2008 but has been reinstated per the Act on Public Holidays (공휴일에 관한 법률).
Reference: https://web.archive.org/web/20260220070517/https://www.law.go.kr/LSW/lsInfoP.do?efYd=20220101&lsiSeq=233829
Type of change
Checklist
make checklocally; all checks and tests passed