Update Australia holidays: add extra ANZAC Day holiday in NSW#3273
Update Australia holidays: add extra ANZAC Day holiday in NSW#3273arkid15r merged 5 commits intovacanza:devfrom
Conversation
simongreen-net
requested review from
KJhellico,
PPsyrius and
arkid15r
as code owners
|
Caution Review failedFailed to post review comments Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
Summary by CodeRabbit
WalkthroughANZAC Day observed-date logic gains a 2026–2027-specific branch: NSW (and ACT/WA where applicable) now uses SAT_SUN_TO_NEXT_MON for observed ANZAC Day in those years; tests updated to assert observed dates for NSW and WA; a NSW 2026–2027 reference link was added. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/countries/test_australia.py (1)
142-156: 🧹 Nitpick | 🔵 TrivialConsider adding a 2027 assertion for NSW.
The implementation covers both 2026 and 2027, but only 2026 is tested here. In 2027, Apr 25 falls on Sunday — still triggers
SAT_SUN_TO_NEXT_MONfor NSW. WA already handles Sunday via its existing_add_observed(dt)for all years ≥ 1973, so WA's 2027 behavior isn't novel. But the NSW 2027 path is new and untested.Suggested addition
elif subdiv in ("NSW", "WA"): self.assertHolidayName(name, holidays, "2026-04-25") self.assertHolidayName(observed_name, holidays, "2026-04-27") + + if subdiv == "NSW": + self.assertHolidayName(name, holidays, "2027-04-25") + self.assertHolidayName(observed_name, holidays, "2027-04-27")
KJhellico
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3273 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 307 307
Lines 18371 18373 +2
Branches 2351 2352 +1
=========================================
+ Hits 18371 18373 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
simongreen-net
force-pushed
the
anzac-day-nsw-2026
branch
from
7c817e0 to
f335f6b
Compare
|
The change is now listed on the NSW Govt website, and I have added a WBM link to the pull request. |
arkid15r
dismissed stale reviews from coderabbitai[bot], KJhellico, and PPsyrius
via
d657e55
arkid15r
left a comment
arkid15r
left a comment
There was a problem hiding this comment.
@simongreen-net thanks for keeping this up to date!
|
4 participants
Proposed change
Add an additional holiday for ANZAC Day in the NSW subdivision of Australia for the next two years only. The NSW government have announced that
The legislative instrument has not yet been created. Given that the holiday is just over two months away, I thought it would be good to create a the PR now. Let me know if you want to wait until the necessary laws have actually passed parliament.
WBM: https://web.archive.org/web/20260215015505/https://www.abc.net.au/news/2026-02-15/nsw-minns-government-anzac-day-extra-public-holiday/106346332
Type of change
holidaysfunctionality in general)Checklist
make checklocally; all checks and tests passed.