Skip to content

Update United Kingdom holidays: add Jun 15, 2026 holiday in Scotland#3272

Merged
arkid15r merged 2 commits intovacanza:devfrom
KJhellico:upd-united-kingdom-sct
Feb 15, 2026
Merged

Update United Kingdom holidays: add Jun 15, 2026 holiday in Scotland#3272
arkid15r merged 2 commits intovacanza:devfrom
KJhellico:upd-united-kingdom-sct

Conversation

@KJhellico
Copy link
Copy Markdown
Collaborator

@KJhellico KJhellico commented Feb 14, 2026

Proposed change

Update United Kingdom holidays: add Jun 15, 2026 holiday in Scotland (to mark Scotland’s participation in the men's football World Cup finals).

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 14, 2026 •
edited
Loading

Caution

Review failed

Failed to post review comments

Summary by CodeRabbit

  • New Features

    • Recognises a Scotland-specific public holiday on 15 June 2026 for Scotland's participation in the FIFA World Cup final.

  • Localization

    • Added and updated translations for the new Scotland holiday across multiple language variants.

  • Data Updates

    • Calendar snapshots updated to include the new 2026 Scotland entry.

  • Tests

    • Added test coverage to verify the Scotland-only holiday and ensure other regions remain unaffected.

Walkthrough

Adds a Scotland-specific special public holiday (2026-06-15) for the FIFA World Cup final and updates translations, a snapshot, and tests to cover the SCT-only holiday.

Changes

Cohort / File(s) Summary
Holiday definition
holidays/countries/united_kingdom.py		 Adds UnitedKingdomStaticHolidays.special_sct_public_holidays with a 2026 entry for Scotland (2026-06-15).
Locale translations
holidays/locale/en_GB/LC_MESSAGES/GB.po, holidays/locale/en_US/LC_MESSAGES/GB.po, holidays/locale/th/LC_MESSAGES/GB.po		 Updates PO metadata, reorders Whit Monday block, and adds translation entry for "Scotland's participation in the FIFA World Cup final".
Tests & snapshots
tests/countries/test_united_kingdom.py, snapshots/countries/GB_SCT.json		 Adds test test_special_subdiv_holidays asserting the 2026-06-15 holiday applies only to SCT; updates GB_SCT snapshot with the new entry.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • arkid15r
  • PPsyrius
🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding a June 15, 2026 holiday in Scotland to the United Kingdom holidays module.
Description check ✅ Passed The description is directly related to the changeset, explaining the motivation (World Cup finals) and confirming standard checks were performed.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into dev

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 14, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c924647) to head (a229b68).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #3272   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          307       307           
  Lines        18370     18371    +1     
  Branches      2351      2351           
=========================================
+ Hits         18370     18371    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

PPsyrius
PPsyrius reviewed Feb 14, 2026
View reviewed changes
@KJhellico @PPsyrius
PR suggestion
a229b68 
Co-authored-by: Panpakorn Siripanich <[email protected]>
Signed-off-by: ~Jhellico <[email protected]>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 14, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

PPsyrius
PPsyrius approved these changes Feb 14, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇬🇧

arkid15r
arkid15r reviewed Feb 15, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r added this pull request to the merge queue Feb 15, 2026
Merged via the queue into vacanza:dev with commit 012cde4 Feb 15, 2026
32 checks passed
@KJhellico KJhellico deleted the upd-united-kingdom-sct branch February 15, 2026 20:52
@arkid15r arkid15r mentioned this pull request Feb 16, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r left review comments

@PPsyrius PPsyrius PPsyrius approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

l10n snapshot test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KJhellico @arkid15r @PPsyrius