Add Germany Stock Exchange holidays by priak388 · Pull Request #3271 · vacanza/holidays

priak388 · 2026-02-14T11:51:33Z

Proposed change

This PR adds support for the Germany Exchange under financial markets by introducing a new file germany_exchange.py.

The implementation follows the established structure and conventions used for other financial market exchange calendars in the project. The file defines the official trading holidays observed by the Germany Exchange, enabling users to retrieve exchange-specific holidays via the financials module.

This addition expands the financial market coverage of the library.

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've read and followed the contributing guidelines.
I've run make check locally; all checks and tests passed.

coderabbitai · 2026-02-14T11:52:13Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

Walkthrough

Adds Germany Stock Exchange (XETR/XFRA): new financial module implementing exchange holidays (start_year=2020) including year-specific Whit Monday behavior (2020–2021), localization PO files, README table entry, registry and package exports, plus unit tests.

Changes

Cohort / File(s)	Summary
Documentation `README.md`	Inserted `Germany Stock Exchange` (`XETR`) row into "Available Financial Markets" table.
Core Implementation `holidays/financial/germany_exchange.py`	New module: `GermanyStockExchange` (market="XETR", default_language="de", supported_languages=("de","en_US"), start_year=2020) with `_populate_public_holidays` registering market closures; Whit Monday included only for 2020–2021. Defines `XETR` and `XFRA` aliases.
Package exports `holidays/financial/__init__.py`	Added re-exports for `GermanyStockExchange`, `XETR`, and `XFRA`.
Registry `holidays/registry.py`	Added `germany_exchange` entry to `FINANCIAL` registry mapping to (`GermanyStockExchange`, `XETR`, `XFRA`).
Localization `holidays/locale/de/LC_MESSAGES/XETR.po`, `holidays/locale/en_US/LC_MESSAGES/XETR.po`	Added PO files for German and en_US translations of XETR market holiday names (German file has empty `msgstr`; en_US provides English translations).
Tests `tests/financial/test_germany_exchange.py`	New test suite validating holiday dates and names, Whit Monday conditional behavior (present 2020–2021, absent thereafter), alias handling, and en_US localization mappings.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Add Bombay Stock Exchange (BSE) holidays #3170 — Adds a financial exchange module and updates FINANCIAL registry and financial exports (similar pattern of new exchange registration).

Suggested reviewers

arkid15r
KJhellico

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title clearly and concisely summarizes the main change: adding Germany Stock Exchange holiday support to the codebase.
Description check	✅ Passed	The PR description clearly relates to the changeset—it describes adding Germany Exchange holidays support via a new germany_exchange.py file, which aligns with the actual changes across multiple files including the new implementation, tests, and locale files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

holidays/financial/germany_exchange.py

Updated holiday methods to accept language-specific names for holidays in Germany. Signed-off-by: priak388 <[email protected]>

holidays/financial/germany_exchange.py

coderabbitai

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@holidays/financial/germany_exchange.py`:
- Around line 51-55: Move the explanatory policy note about Pfingstmontag above
the year check so the holiday-name comment stays directly above the translatable
call; specifically, leave the short comment "# Whit Monday." immediately above
the self._add_whit_monday(tr("Pfingstmontag")) call and relocate the multi-line
explanatory block that references trading/closure behavior to precede the if
self._year in {2020, 2021}: conditional, ensuring the tr("Pfingstmontag") line
remains adjacent to its holiday-name comment.

In `@holidays/locale/en_US/LC_MESSAGES/XETR.po`:
- Around line 52-54: The en_US translation for msgid "Zweiter Weihnachtstag" is
incorrect: replace the current msgstr "Boxing Day" with a literal translation
that matches the German source and adjacent comment, e.g. msgstr "Second
Christmas Day" so the English string faithfully mirrors the original msgid.

In `@tests/financial/test_germany_exchange.py`:
- Around line 24-77: Add a localized assertion for the XETR exchange to exercise
the en_US translations: call assertLocalizedHolidays(XETR(), "en_US", 2020, ...)
(either inside test_xetr or a new small test) and include at least the 2020
dates and expected English names for key holidays (e.g., New Year 2020-01-01,
Good Friday 2020-04-10, Easter Monday 2020-04-13, Labour Day 2020-05-01, Whit
Monday 2020-06-01, Christmas 2020-12-25, Boxing Day 2020-12-26) so the en_US
LC_MESSAGES/XETR.po translations (including the year-limited Whit Monday) are
validated.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 85ad4128-6452-42df-85dc-5e94befe14ec

📥 Commits

Reviewing files that changed from the base of the PR and between c924647 and e6de31d.

📒 Files selected for processing (7)

README.md
holidays/financial/__init__.py
holidays/financial/germany_exchange.py
holidays/locale/de/LC_MESSAGES/XETR.po
holidays/locale/en_US/LC_MESSAGES/XETR.po
holidays/registry.py
tests/financial/test_germany_exchange.py

holidays/financial/germany_exchange.py

holidays/locale/en_US/LC_MESSAGES/XETR.po

tests/financial/test_germany_exchange.py

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@holidays/locale/en_US/LC_MESSAGES/XETR.po`:
- Around line 45-46: Add the missing descriptive comment for the Pfingstmontag
translation: insert a translator comment line (e.g., "#. Whit Monday.")
immediately above the msgid "Pfingstmontag" / msgstr "Whit Monday" entry so it
matches the other entries and tooling that expects those comments.

In `@tests/financial/test_germany_exchange.py`:
- Around line 76-77: Add an assertion to ensure the XFRA alias is registered
like XETR: in tests/financial/test_germany_exchange.py update the test_xetr test
(or add a new test_xfra) to import XFRA and assert that XFRA() returns an
instance of GermanyStockExchange, referencing the existing test_xetr, XETR,
XFRA, and GermanyStockExchange symbols so both aliases are validated.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: c75c49fd-23f2-4173-84c5-98def3543c14

📥 Commits

Reviewing files that changed from the base of the PR and between 208ced3 and 9cdd404.

📒 Files selected for processing (3)

holidays/financial/germany_exchange.py
holidays/locale/en_US/LC_MESSAGES/XETR.po
tests/financial/test_germany_exchange.py

holidays/locale/en_US/LC_MESSAGES/XETR.po

tests/financial/test_germany_exchange.py

PPsyrius

We're almost there 🎉

holidays/locale/de/LC_MESSAGES/XETR.po

holidays/locale/en_US/LC_MESSAGES/XETR.po

tests/financial/test_germany_exchange.py

holidays/locale/en_US/LC_MESSAGES/XETR.po

holidays/financial/germany_exchange.py

holidays/locale/de/LC_MESSAGES/XETR.po

holidays/locale/en_US/LC_MESSAGES/XETR.po

Co-authored-by: Panpakorn Siripanich <[email protected]> Signed-off-by: priak388 <[email protected]>

PPsyrius

Don't forget to update l10n as well - this is probably the final review before merging 🎉

AFAIK, while Xetra's own record excludes holidays which fell on weekends - that's only the case for one of the data sources, they're otherwise included elsewhere, so I don't think we need to implement it like the National Stock Exchange of India market holidays.

holidays/financial/germany_exchange.py

Co-authored-by: Panpakorn Siripanich <[email protected]> Signed-off-by: priak388 <[email protected]>

priak388 · 2026-03-11T11:20:31Z

@PPsyrius Thank you for your review, sir. I have updated the code based on your suggestions.

holidays/financial/germany_exchange.py

Co-authored-by: Panpakorn Siripanich <[email protected]> Signed-off-by: priak388 <[email protected]>

sonarqubecloud · 2026-03-11T12:15:15Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

PPsyrius

LGTM 🇩🇪

KJhellico

LGTM.

priak388 · 2026-03-11T13:23:43Z

Thank you for the review and approval. I appreciate your time and feedback!

arkid15r

Great work @priak388!

Thanks for the contribution!

Signed-off-by: priak388 <[email protected]> Co-authored-by: Panpakorn Siripanich <[email protected]> Co-authored-by: kris <[email protected]> Co-authored-by: ~Jhellico <[email protected]>

priak388 added 2 commits February 11, 2026 15:49

Remove unused month imports

3e60277

Remove unused month imports

683803e

priak388 requested review from KJhellico, PPsyrius and arkid15r as code owners February 14, 2026 11:51

github-actions bot added the test label Feb 14, 2026

KJhellico reviewed Feb 14, 2026

View reviewed changes

holidays/financial/germany_exchange.py Outdated Show resolved Hide resolved

holidays/financial/germany_exchange.py Show resolved Hide resolved

Refactor GermanyStockExchange to use HolidayBase

bab41a4

Updated holiday methods to accept language-specific names for holidays in Germany. Signed-off-by: priak388 <[email protected]>

coderabbitai bot previously approved these changes Feb 17, 2026

View reviewed changes

PPsyrius reviewed Feb 17, 2026

View reviewed changes

holidays/financial/germany_exchange.py Outdated Show resolved Hide resolved

KJhellico marked this pull request as draft February 28, 2026 12:35

Remove unused month imports

e6de31d

priak388 marked this pull request as ready for review March 9, 2026 08:01

priak388 dismissed coderabbitai[bot]’s stale review via e6de31d March 9, 2026 08:02

github-actions bot added the l10n label Mar 9, 2026

priak388 requested review from KJhellico and PPsyrius March 9, 2026 08:07

Merge branch 'dev' into dev

208ced3

coderabbitai bot reviewed Mar 9, 2026

View reviewed changes

holidays/financial/germany_exchange.py Outdated Show resolved Hide resolved

holidays/locale/en_US/LC_MESSAGES/XETR.po Outdated Show resolved Hide resolved

tests/financial/test_germany_exchange.py Outdated Show resolved Hide resolved

Remove unused month imports

9cdd404

coderabbitai bot reviewed Mar 9, 2026

View reviewed changes

holidays/locale/en_US/LC_MESSAGES/XETR.po Show resolved Hide resolved

tests/financial/test_germany_exchange.py Outdated Show resolved Hide resolved

fixed on suggestion of coderabbit

f20bb17

PPsyrius reviewed Mar 9, 2026

View reviewed changes

holidays/locale/de/LC_MESSAGES/XETR.po Show resolved Hide resolved

holidays/locale/en_US/LC_MESSAGES/XETR.po Show resolved Hide resolved

priak388 and others added 5 commits March 10, 2026 12:58

Update holidays/locale/de/LC_MESSAGES/XETR.po

7777fc4

Co-authored-by: Panpakorn Siripanich <[email protected]> Signed-off-by: priak388 <[email protected]>

Update holidays/locale/de/LC_MESSAGES/XETR.po

ba1c5d0

Co-authored-by: Panpakorn Siripanich <[email protected]> Signed-off-by: priak388 <[email protected]>

Update holidays/locale/en_US/LC_MESSAGES/XETR.po

541be80

Co-authored-by: Panpakorn Siripanich <[email protected]> Signed-off-by: priak388 <[email protected]>

Update tests/financial/test_germany_exchange.py

3c7c0c5

Co-authored-by: Panpakorn Siripanich <[email protected]> Signed-off-by: priak388 <[email protected]>

Update tests/financial/test_germany_exchange.py

69d5100

Co-authored-by: Panpakorn Siripanich <[email protected]> Signed-off-by: priak388 <[email protected]>

priak388 and others added 3 commits March 11, 2026 12:58

Update holidays/financial/germany_exchange.py

be25270

Co-authored-by: Panpakorn Siripanich <[email protected]> Signed-off-by: priak388 <[email protected]>

Update tests/financial/test_germany_exchange.py

22e1588

Co-authored-by: Panpakorn Siripanich <[email protected]> Signed-off-by: priak388 <[email protected]>

Update tests/financial/test_germany_exchange.py

409e801

Co-authored-by: Panpakorn Siripanich <[email protected]> Signed-off-by: priak388 <[email protected]>

priak388 requested a review from PPsyrius March 11, 2026 07:31

PPsyrius reviewed Mar 11, 2026

View reviewed changes

holidays/financial/germany_exchange.py Outdated Show resolved Hide resolved

Update holidays/financial/germany_exchange.py

6f3dcd4

Co-authored-by: Panpakorn Siripanich <[email protected]> Signed-off-by: priak388 <[email protected]>

priak388 requested a review from PPsyrius March 11, 2026 10:22

Error fixed

b261297

PPsyrius reviewed Mar 11, 2026

View reviewed changes

holidays/financial/germany_exchange.py Show resolved Hide resolved

Update holidays/financial/germany_exchange.py

fafa524

Co-authored-by: Panpakorn Siripanich <[email protected]> Signed-off-by: priak388 <[email protected]>

priak388 requested a review from PPsyrius March 11, 2026 12:17

PPsyrius approved these changes Mar 11, 2026

View reviewed changes

KJhellico approved these changes Mar 11, 2026

View reviewed changes

arkid15r added this pull request to the merge queue Mar 12, 2026

arkid15r reviewed Mar 12, 2026

View reviewed changes

github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 12, 2026

PPsyrius added this pull request to the merge queue Mar 12, 2026

PPsyrius mentioned this pull request Mar 12, 2026

Update CONTRIBUTORS #3325

Merged

9 tasks

Merged via the queue into vacanza:dev with commit 664424c Mar 12, 2026
32 checks passed

arkid15r mentioned this pull request Mar 16, 2026

v0.93 #3333

Merged

coderabbitai bot mentioned this pull request Mar 20, 2026

Update German Exchange holidays: add Thai, Ukrainian language support #3354

Merged

9 tasks

PPsyrius mentioned this pull request Mar 24, 2026

Update India holidays: add missing Mizoram state holidays #3388

Closed

9 tasks

coderabbitai bot mentioned this pull request Mar 24, 2026

Add Shanghai Stock Exchange (SSE) holidays #3403

Merged

9 tasks

coderabbitai bot mentioned this pull request Apr 2, 2026

Add Shenzhen Stock Exchange (SZSE) holidays #3453

Merged

9 tasks

Uh oh!

Conversation

priak388 commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai bot commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

PPsyrius left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PPsyrius left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

priak388 commented Mar 11, 2026

Uh oh!

Uh oh!

sonarqubecloud bot commented Mar 11, 2026

Quality Gate passed

Uh oh!

PPsyrius left a comment

Choose a reason for hiding this comment

Uh oh!

KJhellico left a comment

Choose a reason for hiding this comment

Uh oh!

priak388 commented Mar 11, 2026

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

priak388 commented Feb 14, 2026 •

edited

Loading

coderabbitai bot commented Feb 14, 2026 •

edited

Loading