Add Japan Exchange Group (JPX) holidays by adityaanand05 · Pull Request #3270 · vacanza/holidays

adityaanand05 · 2026-02-14T09:52:02Z

Proposed change

This PR adds support for the Japan Exchange under financial markets by introducing a new file japan_exchange.py.

The implementation follows the existing financial market structure and conventions used across the project. The file defines the official trading holidays observed by the Japan Exchange, enabling users to retrieve exchange-specific holidays through the financials module.

This addition expands financial market coverage within the library.

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've read and followed the contributing guidelines.
I've run make check locally; all checks and tests passed.

- Implemented proper category tracking in JapanExchange - Fixed localization files and generated .mo files for JPX - Updated documentation formatting - Fixed mypy type annotation for _category

- Removed self._category dict that was never read/used - Removed _add_holiday, _populate_bank_holidays, _populate_public_holidays overrides - Simplified implementation by ~30 lines without changing functionality - All tests still pass

coderabbitai · 2026-02-14T09:52:22Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

Walkthrough

Adds a Japan Exchange (XJPX/JPX/TSE/OSE) financial calendar, registers and re-exports it, updates README market listing, adds XJPX locale PO files (en_US, ja, th), modifies JP locale PO files, tweaks holiday_base entity_code fallback, and adds tests for JPX behavior.

Changes

Cohort / File(s)	Summary
Core implementation `holidays/financial/japan_exchange.py`, `holidays/financial/__init__.py`, `holidays/registry.py`	New `JapanExchange` calendar (market="XJPX", start_year=1949) with market-closure rules (adds Jan 2, Jan 3, Dec 31 as market holidays), `supported_categories=(PUBLIC,)`, alias classes `XJPX`, `JPX`, `TSE`, `OSE`; re-exported from package; `FINANCIAL` registry entry `japan_exchange` added.
Tests `tests/financial/test_japan_exchange.py`	New test suite `TestJapanExchange` covering init, market holiday dates (including weekend/substitute handling), citizens holiday, special one-offs, and pre/post start-year bounds.
Documentation `README.md`	Inserted "Japan Exchange" row into the "Available Financial Markets" table with code `XJPX` and supported languages `en_US, ja, th`.
Locale: JP (updated) `holidays/locale/en_US/LC_MESSAGES/JP.po`, `holidays/locale/ja/LC_MESSAGES/JP.po`, `holidays/locale/th/LC_MESSAGES/JP.po`	Added translations/entries for `市場休業日` (Market Holiday) and `銀行休業日` (Bank Holiday); reorganized substitute/national sections and restructured multiple JP entries.
Locale: XJPX (new) `holidays/locale/en_US/LC_MESSAGES/XJPX.po`, `holidays/locale/ja/LC_MESSAGES/XJPX.po`, `holidays/locale/th/LC_MESSAGES/XJPX.po`	New PO files for XJPX providing translations and headers for JPX market holidays in English, Japanese, and Thai.
Core utility tweak `holidays/holiday_base.py`	Adjusted `_entity_code` to prefer `market` when `country` is falsy (ensures fallback uses `market` for empty/None country values).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Update XNYS holidays: add half-day holidays #3111 — Related changes around financial-market supported_categories export/registry conventions and category propagation.

Suggested reviewers

KJhellico
arkid15r
PPsyrius

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 61.54% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description is directly related to the changeset, explaining the purpose of adding japan_exchange.py for Japan Exchange financial market support with proper context about following project conventions.
Title check	✅ Passed	The title clearly and concisely describes the main change: adding Japan Exchange Group (JPX) holidays support to the codebase.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

holidays/financial/japan_exchange.py

holidays/locale/en_US/LC_MESSAGES/JP.po

Co-authored-by: ~Jhellico <[email protected]> Signed-off-by: Aditya Anand <[email protected]>

adityaanand05 · 2026-03-05T04:56:44Z

@KJhellico Sir i have made the changes

holidays/financial/japan_exchange.py

holidays/locale/en_US/LC_MESSAGES/XJPX.po

holidays/locale/ja/LC_MESSAGES/XJPX.po

tests/financial/test_japan_exchange.py

Co-authored-by: ~Jhellico <[email protected]> Signed-off-by: Aditya Anand <[email protected]>

adityaanand05 · 2026-03-05T14:38:31Z

@KJhellico Sir, all test cases are passing after the latest changes. Please let me know what I should do next.

KJhellico

LGTM.

adityaanand05 · 2026-03-05T14:46:01Z

@KJhellico Thank you so much for the review! I'm really happy everything looks good. This was my first open-source contribution, so it means a lot. I really appreciate your guidance and feedback. 🚀

sonarqubecloud · 2026-03-06T02:18:04Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

PPsyrius

LGTM 🇯🇵

adityaanand05 · 2026-03-06T04:32:40Z

@KJhellico @arkid15r @PPsyrius
Hi everyone 👋

I just wanted to take a moment to sincerely thank all the mentors and maintainers at Vacanza for their support and guidance throughout this contribution 🙏. I’m really grateful for the time you took to review the code, provide feedback, and help improve the PR.

This was my first open-source contribution, so getting the chance to learn the workflow, understand the project structure, and collaborate with experienced developers has been an amazing experience for me 🚀.

Thank you again for maintaining such a great project and for being so welcoming to new contributors. I’m looking forward to contributing more in the future! 😊

Best regards,
Aditya Anand

arkid15r · 2026-03-06T05:13:31Z

@KJhellico @arkid15r @PPsyrius Hi everyone 👋

I just wanted to take a moment to sincerely thank all the mentors and maintainers at Vacanza for their support and guidance throughout this contribution 🙏. I’m really grateful for the time you took to review the code, provide feedback, and help improve the PR.

This was my first open-source contribution, so getting the chance to learn the workflow, understand the project structure, and collaborate with experienced developers has been an amazing experience for me 🚀.

Thank you again for maintaining such a great project and for being so welcoming to new contributors. I’m looking forward to contributing more in the future! 😊

Best regards, Aditya Anand

Thanks for being part of this Aditya 👍

adityaanand05 added 15 commits February 7, 2026 06:21

Added japan_exchange.py to financial

c4ab807

Added japan_exchange.py to financial

b638446

Added japan_exchange.py to financial

ae408d2

Added japan_exchange.py to financial

d999594

Added japan_exchange.py to financial

b8537ce

added inheritance to japan_exchange.py

9272f92

added inheritance to japan_exchange.py

a19841e

added inheritance to japan_exchange.py

ecef23e

added inheritance to japan_exchange.py

f8d4205

added inheritance to japan_exchange.py

5e01641

added inheritance to japan_exchange.py

b7fb969

added inheritance to japan_exchange.py

f074411

added inheritance to japan_exchange.py

9e2cc68

Fix JapanExchange inheritance and attributes

1fda7cb

- Implemented proper category tracking in JapanExchange - Fixed localization files and generated .mo files for JPX - Updated documentation formatting - Fixed mypy type annotation for _category

Refactor: Remove unused category tracking code

7d36b3e

- Removed self._category dict that was never read/used - Removed _add_holiday, _populate_bank_holidays, _populate_public_holidays overrides - Simplified implementation by ~30 lines without changing functionality - All tests still pass

adityaanand05 requested review from KJhellico, PPsyrius and arkid15r as code owners February 14, 2026 09:52

github-actions bot added l10n test labels Feb 14, 2026

KJhellico requested changes Feb 14, 2026

View reviewed changes

test_japan_exchange.py fixed

e9f880d

adityaanand05 closed this Feb 16, 2026

adityaanand05 added 2 commits February 16, 2026 16:41

Fix test_japan_exchange.py

7fdf474

Fix test_japan_exchange.py

70f8b38

adityaanand05 reopened this Feb 16, 2026

adityaanand05 and others added 2 commits February 16, 2026 23:12

Apply suggestion from @KJhellico

e6dc36a

Co-authored-by: ~Jhellico <[email protected]> Signed-off-by: Aditya Anand <[email protected]>

Apply suggestion from @KJhellico

77a2263

Co-authored-by: ~Jhellico <[email protected]> Signed-off-by: Aditya Anand <[email protected]>

coderabbitai bot previously approved these changes Feb 16, 2026

View reviewed changes

fixed l10n tests and test_code

d271c72

Merge branch 'dev' into dev

140137b

KJhellico reviewed Mar 5, 2026

View reviewed changes

KJhellico changed the title ~~Add japan_exchange.py for Japan Exchange holidays~~ Add Japan Exchange Group (JPX) holidays Mar 5, 2026

adityaanand05 and others added 5 commits March 5, 2026 18:56

Update holidays/locale/en_US/LC_MESSAGES/XJPX.po

5345e45

Co-authored-by: ~Jhellico <[email protected]> Signed-off-by: Aditya Anand <[email protected]>

Update holidays/financial/japan_exchange.py

0955eaa

Co-authored-by: ~Jhellico <[email protected]> Signed-off-by: Aditya Anand <[email protected]>

Update holidays/locale/en_US/LC_MESSAGES/XJPX.po

d2888e7

Co-authored-by: ~Jhellico <[email protected]> Signed-off-by: Aditya Anand <[email protected]>

Update holidays/locale/ja/LC_MESSAGES/XJPX.po

f0de12b

Co-authored-by: ~Jhellico <[email protected]> Signed-off-by: Aditya Anand <[email protected]>

fixed l10n tests and test_code

e3e138f

adityaanand05 requested a review from KJhellico March 5, 2026 13:58

KJhellico previously approved these changes Mar 5, 2026

View reviewed changes

Update code

d4dded6

arkid15r dismissed KJhellico’s stale review via d4dded6 March 6, 2026 00:17

github-actions bot added the script label Mar 6, 2026

arkid15r requested a review from KJhellico March 6, 2026 01:08

arkid15r enabled auto-merge March 6, 2026 01:09

Merge branch 'dev' into dev

6a8eb85

PPsyrius approved these changes Mar 6, 2026

View reviewed changes

arkid15r added this pull request to the merge queue Mar 6, 2026

Merged via the queue into vacanza:dev with commit 1d6535d Mar 6, 2026
32 checks passed

coderabbitai bot mentioned this pull request Mar 9, 2026

Add Germany Stock Exchange holidays #3271

Merged

9 tasks

arkid15r mentioned this pull request Mar 16, 2026

v0.93 #3333

Merged

PPsyrius mentioned this pull request Mar 24, 2026

Update India holidays: add missing Mizoram state holidays #3388

Closed

9 tasks

Uh oh!

Conversation

adityaanand05 commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai bot commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adityaanand05 commented Mar 5, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adityaanand05 commented Mar 5, 2026

Uh oh!

KJhellico left a comment

Choose a reason for hiding this comment

Uh oh!

adityaanand05 commented Mar 5, 2026

Uh oh!

sonarqubecloud bot commented Mar 6, 2026

Quality Gate passed

Uh oh!

PPsyrius left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

adityaanand05 commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arkid15r commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

adityaanand05 commented Feb 14, 2026 •

edited

Loading

coderabbitai bot commented Feb 14, 2026 •

edited

Loading

adityaanand05 commented Mar 6, 2026 •

edited

Loading