Update Ireland holidays: add OPTIONAL category#3260
Conversation
PredictiveManish
requested review from
KJhellico,
PPsyrius and
arkid15r
as code owners
Summary by CodeRabbit
WalkthroughAdds OPTIONAL and PUBLIC imports and declares Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PPsyrius
left a comment
PPsyrius
left a comment
There was a problem hiding this comment.
You might want to implement "Good Friday" itself for the separate OPTIONAL supported category instead - see #3240, #2490 for examples and check out the contributing guide https://holidays.readthedocs.io/en/latest/contributing/ for test setups
You'll need to do the following as well:
- Update readme file to include
OPTIONALcategory support for Ireland's - Add this for
test_ireland.pyfile:
def test_good_friday(self):
name = "Good Friday"
self.assertNoHolidayName(name)
self.assertOptionalHolidayName(
name,
"2020-04-10",
"2021-04-02",
"2022-04-15",
"2023-04-07",
"2024-03-29",
"2025-04-18",
)
self.assertOptionalHolidayName(name, self.full_range)- Add your own name to the
CONTRIBUTORSfile
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
PPsyrius
changed the title
OPTIONAL category
Co-authored-by: Panpakorn Siripanich <[email protected]> Signed-off-by: Manish Tiwari <[email protected]>
Co-authored-by: Panpakorn Siripanich <[email protected]> Signed-off-by: Manish Tiwari <[email protected]>
Co-authored-by: Panpakorn Siripanich <[email protected]> Signed-off-by: Manish Tiwari <[email protected]>
Co-authored-by: Panpakorn Siripanich <[email protected]> Signed-off-by: Manish Tiwari <[email protected]>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3260 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 307 307
Lines 18377 18381 +4
Branches 2358 2358
=========================================
+ Hits 18377 18381 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arkid15r
left a comment
arkid15r
left a comment
There was a problem hiding this comment.
Thanks for the contribution @PredictiveManish 👍
4 participants
Proposed change
This PR adds optional Good Friday holiday support to the Ireland calendar via a new include_good_friday parameter.
Fixes #3255
While Good Friday is not an official public holiday in Ireland, it is widely observed by:
This optional parameter allows users to include Good Friday for financial calculations, business day adjustments, and other use cases where it's relevant, while keeping the default behavior consistent with official public holiday listings that don't include Good Friday.
Type of change
holidaysfunctionality in general)Checklist
make checklocally; all checks and tests passed.