Update Germany holidays: add catholic holidays to Augsburg by Estartu · Pull Request #3244 · vacanza/holidays

Estartu · 2026-01-30T08:58:43Z

Proposed change

There is a special subdivision for the city Augsburg. Augsburg is a catholic city. Therefore all Bavarian holidays for predominantly catholic regions must also be applied.

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've read and followed the contributing guidelines.
I've run make check locally; all checks and tests passed.

Signed-off-by: Gerhard Schmidt <[email protected]>

coderabbitai · 2026-01-30T08:59:04Z

Summary by CodeRabbit

Bug Fixes
- Augsburg calendars and holiday lookups now include the Catholic Assumption Day (Aug 15), matching regional observance.
Chores
- Contributors list updated to add Gerhard Schmidt.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Walkthrough

Adds Assumption Day (Mariä Himmelfahrt) for the Augsburg subdivision, updates tests to expect Augsburg to observe Assumption Day, and adds contributor "Gerhard Schmidt" to CONTRIBUTORS.

Changes

Cohort / File(s)	Summary
Augsburg holiday logic `holidays/countries/germany.py`	Calls `_add_assumption_of_mary_day(tr("Mariä Himmelfahrt"))` in Augsburg subdivision population to include Assumption Day.
Tests `tests/countries/test_germany.py`	Expands Assumption Day test condition from `subdiv == "SL"` to `subdiv in {"SL", "Augsburg"}`.
Contributors `CONTRIBUTORS`	Inserts `Gerhard Schmidt` after `Gabriel Trabanco`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Update Germany holidays: add Augsburg Peace Festival for Augsburg #2750: Modifies Augsburg subdivision holiday population; closely related to this change.

Suggested labels

l10n

Suggested reviewers

KJhellico
PPsyrius
arkid15r

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately reflects the main change: adding Catholic holidays (Assumption Day) to Augsburg in the Germany holidays module.
Description check	✅ Passed	The description clearly explains the rationale for the change—Augsburg's Catholic nature requires applying Bavarian Catholic holidays—and is directly related to the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-01-30T09:04:50Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (f010115) to head (9ac54a0).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #3244   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          307       307           
  Lines        18376     18377    +1     
  Branches      2358      2358           
=========================================
+ Hits         18376     18377    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

PPsyrius

Feel free to add your name to the CONTRIBUTORS file as well 👍

holidays/countries/germany.py

tests/countries/test_germany.py

PPsyrius

LGTM 🇩🇪

holidays/countries/germany.py

Signed-off-by: Gerhard Schmidt <[email protected]>

my priority is to fix the error as soon as possible. Fundamental discussions are not mine. Have it as you want but please not the added future risk. Co-authored-by: ~Jhellico <[email protected]> Signed-off-by: Gerhard Schmidt <[email protected]>

coderabbitai

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

tests/countries/test_germany.py (1)
234-240: 🧹 Nitpick | 🔵 Trivial

Update the comment to include Augsburg.

The comment on line 234 still says # Saarland. but the condition now includes both Saarland and Augsburg. Keep it accurate.
📝 Suggested comment update
-            # Saarland.
+            # Saarland, Augsburg.
             if subdiv in ("SL", "Augsburg"):

tests/countries/test_germany.py

Co-authored-by: ~Jhellico <[email protected]> Signed-off-by: Gerhard Schmidt <[email protected]>

sonarqubecloud · 2026-02-01T12:10:27Z

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

KJhellico

LGTM.

arkid15r

LGTM, thanks @Estartu 👍

Estartu added 2 commits January 30, 2026 09:25

Augsburg is catholic - by_catholic holidays also apply

f71e595

Signed-off-by: Gerhard Schmidt <[email protected]>

Include Augsburg in subdivisions for 'Mariä Himmelfahrt' test

9ec9049

Estartu requested review from KJhellico, PPsyrius and arkid15r as code owners January 30, 2026 08:58

github-actions bot added the test label Jan 30, 2026

PPsyrius reviewed Jan 30, 2026

View reviewed changes

holidays/countries/germany.py Outdated Show resolved Hide resolved

tests/countries/test_germany.py Outdated Show resolved Hide resolved

PPsyrius changed the title ~~Augsburg is catholic - by_catholic holidays also apply~~ Update Germany holidays: fix Augsburg not getting Bavaria's CATHOLIC holidays. Jan 30, 2026

coderabbitai bot previously approved these changes Jan 30, 2026

View reviewed changes

PPsyrius previously approved these changes Jan 30, 2026

View reviewed changes

KJhellico reviewed Jan 30, 2026

View reviewed changes

holidays/countries/germany.py Outdated Show resolved Hide resolved

KJhellico changed the title ~~Update Germany holidays: fix Augsburg not getting Bavaria's CATHOLIC holidays.~~ Update Germany holidays: add catholic holidays to Augsburg Jan 30, 2026

Update CONTRIBUTORS

0871362

Signed-off-by: Gerhard Schmidt <[email protected]>

Estartu dismissed stale reviews from PPsyrius and coderabbitai[bot] via 0871362 January 30, 2026 10:02

coderabbitai bot previously approved these changes Feb 1, 2026

View reviewed changes

Update holidays/countries/germany.py

ac7f80d

my priority is to fix the error as soon as possible. Fundamental discussions are not mine. Have it as you want but please not the added future risk. Co-authored-by: ~Jhellico <[email protected]> Signed-off-by: Gerhard Schmidt <[email protected]>

Estartu dismissed coderabbitai[bot]’s stale review via ac7f80d February 1, 2026 09:03

coderabbitai bot reviewed Feb 1, 2026

View reviewed changes

coderabbitai bot previously approved these changes Feb 1, 2026

View reviewed changes

Merge branch 'dev' into dev

8bb5546

KJhellico reviewed Feb 1, 2026

View reviewed changes

tests/countries/test_germany.py Outdated Show resolved Hide resolved

Update tests/countries/test_germany.py

9ac54a0

Co-authored-by: ~Jhellico <[email protected]> Signed-off-by: Gerhard Schmidt <[email protected]>

Estartu dismissed coderabbitai[bot]’s stale review via 9ac54a0 February 1, 2026 12:09

coderabbitai bot approved these changes Feb 1, 2026

View reviewed changes

KJhellico approved these changes Feb 1, 2026

View reviewed changes

PPsyrius approved these changes Feb 1, 2026

View reviewed changes

arkid15r added this pull request to the merge queue Feb 2, 2026

arkid15r reviewed Feb 2, 2026

View reviewed changes

Merged via the queue into vacanza:dev with commit 5df9d73 Feb 2, 2026
31 of 32 checks passed

KJhellico mentioned this pull request Feb 2, 2026

v0.90 #3249

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update Germany holidays: add catholic holidays to Augsburg#3244

Update Germany holidays: add catholic holidays to Augsburg#3244
arkid15r merged 6 commits intovacanza:devfrom
Estartu:dev

Estartu commented Jan 30, 2026

Uh oh!

coderabbitai bot commented Jan 30, 2026 •

edited

Loading

Uh oh!

codecov bot commented Jan 30, 2026 •

edited

Loading

Uh oh!

PPsyrius left a comment

Uh oh!

Uh oh!

Uh oh!

PPsyrius left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Feb 1, 2026

Uh oh!

KJhellico left a comment

Uh oh!

arkid15r left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Estartu commented Jan 30, 2026

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Uh oh!

codecov bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

PPsyrius left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

PPsyrius left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Feb 1, 2026

Quality Gate failed

Uh oh!

KJhellico left a comment

Choose a reason for hiding this comment

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai bot commented Jan 30, 2026 •

edited

Loading

codecov bot commented Jan 30, 2026 •

edited

Loading