Reference maintenance: archive links, fix broken, remove unused by PPsyrius · Pull Request #3238 · vacanza/holidays

PPsyrius · 2026-01-22T07:16:58Z

Proposed change

Archive 11 reference links.
Fix 1 broken reference links.
Remove 2 unused reference links (there's no existing archive for them, and their links are unreachable ATM - their removal won't affect the current holidays logic)

There are 3 remaining links still unaddressed by this PR:

python scripts/archive_links.py --show-only

Scan complete. Found links in 2 file(s). Found 3 unique URLs.
Check-only mode: Printing all URLs that would need archiving
FOUND: URLs that need archiving

File: /mnt/d/python-holidays/holidays/countries/sudan.py
  https://sudantribune.com/article/25544

File: /mnt/d/python-holidays/holidays/countries/turks_and_caicos_islands.py
  https://www.facebook.com/pressofficetcig/photos/a.349345645161128/3511371698958491/?type=3
  https://www.facebook.com/pressofficetcig/photos/a.349345645161128/4515540038541647/?type=3

The last 3 depends on whether solution in #3233 works out or not

Resolves #2509

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've read and followed the contributing guidelines.
I've run make check locally; all checks and tests passed.

coderabbitai · 2026-01-22T07:17:24Z

Caution

Review failed

Failed to post review comments

Summary by CodeRabbit

Documentation
- Updated numerous holiday reference links to archived versions for long-term stability and accessibility.
- Reformatted and expanded reference entries; removed several outdated checklist lines and stray commented references.
- Minor comment/url formatting tweaks across country docs.
- No changes to holiday logic, calculations, public APIs, or runtime behavior—documentation-only edits.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Walkthrough

Documentation-only edits across multiple country modules: mostly replacing live reference URLs with archived (Wayback) links, small docstring/comment cleanups, and removal of a couple of checked-year entries. No changes to holiday generation logic, control flow, or public APIs. (≈28 words)

Changes

Cohort / File(s)	Summary
Archival reference updates `holidays/countries/australia.py`, `holidays/countries/estonia.py`, `holidays/countries/italy.py`, `holidays/countries/liberia.py`, `holidays/countries/moldova.py`, `holidays/countries/india.py`	Replaced direct reference URLs with archived (web.archive.org) links in class docstrings/references. Purely metadata updates; no logic/API changes.
Docstring/comment cleanups `holidays/countries/cambodia.py`, `holidays/countries/sudan.py`, `holidays/countries/laos.py`, `holidays/countries/tonga.py`	Added/updated archival links, reformatted a comment URL, removed outdated "Checked With" years, and deleted commented reference lines. All non-functional text edits.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Possibly related PRs

Add archive-links Makefile target #3218 — Similar archival URL replacements in country modules (e.g., australia.py, estonia.py, italy.py).
Docstring cleanup for Indochinese countries #2505 — Documentation/comment edits in holidays/countries/cambodia.py.
Clean up unicode URLs #2580 — Docstring/reference URL edits across country modules (overlapping targets like italy.py).

Suggested labels

gsoc2025

Suggested reviewers

arkid15r
KJhellico

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main changeset: archiving reference links, fixing broken ones, and removing unused references across multiple country modules.
Description check	✅ Passed	The description clearly outlines the proposed changes with specific counts and explains which links remain unaddressed, directly relating to the reference maintenance work.
Linked Issues check	✅ Passed	The PR addresses issue `#2509` by archiving 11 reference links and removing 2 unused ones from multiple country modules (Australia, Cambodia, Estonia, India, Italy, Liberia, Moldova, Tonga, Laos, and Sudan).
Out of Scope Changes check	✅ Passed	All changes are in-scope documentation and reference URL updates. No code logic, control flow, or exported API changes were introduced.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-01-22T07:19:21Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (9b75806) to head (b66ad0f).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #3238   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          307       307           
  Lines        18310     18310           
  Branches      2331      2331           
=========================================
  Hits         18310     18310

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

coderabbitai

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

holidays/countries/cambodia.py (1)

24-30: Keep reference ordering consistent (Wikipedia first).
Please reorder the References list so the Wikipedia link is first, then official sources, then article-specific sources. Based on learnings, ...

♻️ Proposed reorder

     References:
-        * <https://web.archive.org/web/20241117220849/https://www.nbc.gov.kh/english/news_and_events/official_holiday.php>
-        * <https://web.archive.org/web/20250401111433/https://www.nbc.gov.kh/news_and_events/official_holiday.php>
         * <https://en.wikipedia.org/wiki/Public_holidays_in_Cambodia>
+        * <https://web.archive.org/web/20241117220849/https://www.nbc.gov.kh/english/news_and_events/official_holiday.php>
+        * <https://web.archive.org/web/20250401111433/https://www.nbc.gov.kh/news_and_events/official_holiday.php>
         * <https://web.archive.org/web/20250427180236/https://admin.taftac-cambodia.org/public/pdf_file/regulation_1704245695_Z7IALJjE.pdf>
         * <http://archive.today/2026.01.22-052218/https://www.khmertimeskh.com/501424903/24-public-holidays-for-2024-peace-day-now-included/>
         * <http://archive.today/2026.01.22-051938/https://www.khmertimeskh.com/501551204/govt-announces-22-public-holidays-for-next-year/>

sonarqubecloud · 2026-01-22T08:14:15Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

arkid15r

I didn't check every link but I trust you on this

LGTM

KJhellico

LGTM.

Archive Reference Links

8c4eb66

coderabbitai bot reviewed Jan 22, 2026

View reviewed changes

coderabbitai bot previously approved these changes Jan 22, 2026

View reviewed changes

Replace Lao's deprecated reference links

b66ad0f

PPsyrius dismissed coderabbitai[bot]’s stale review via b66ad0f January 22, 2026 08:13

PPsyrius marked this pull request as ready for review January 22, 2026 08:20

PPsyrius requested review from KJhellico and arkid15r as code owners January 22, 2026 08:20

arkid15r reviewed Jan 22, 2026

View reviewed changes

arkid15r enabled auto-merge January 22, 2026 20:43

KJhellico approved these changes Jan 22, 2026

View reviewed changes

arkid15r added this pull request to the merge queue Jan 22, 2026

Merged via the queue into vacanza:dev with commit 632c26e Jan 22, 2026
32 checks passed

PPsyrius deleted the reference_rescue branch January 23, 2026 02:59

KJhellico mentioned this pull request Feb 2, 2026

v0.90 #3249

Merged

coderabbitai bot mentioned this pull request Mar 20, 2026

Refactor WM archiver script #3356

Merged

9 tasks

coderabbitai bot mentioned this pull request Mar 30, 2026

docs: fix minor English spelling errors in 12 country modules #3468

Draft

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reference maintenance: archive links, fix broken, remove unused#3238

Reference maintenance: archive links, fix broken, remove unused#3238
arkid15r merged 2 commits intovacanza:devfrom
PPsyrius:reference_rescue

PPsyrius commented Jan 22, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Jan 22, 2026 •

edited

Loading

Review failed

Uh oh!

codecov bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

sonarqubecloud bot commented Jan 22, 2026

Uh oh!

arkid15r left a comment

Uh oh!

KJhellico left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

PPsyrius commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Summary by CodeRabbit

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Uh oh!

codecov bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jan 22, 2026

Quality Gate passed

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

KJhellico left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

PPsyrius commented Jan 22, 2026 •

edited

Loading

coderabbitai bot commented Jan 22, 2026 •

edited

Loading

codecov bot commented Jan 22, 2026 •

edited

Loading